Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-86drpnxv7 - Create a CONTRIBUTING.md file #108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LeonardoDizConde
Copy link
Contributor

No description provided.

@melanke
Copy link
Contributor

melanke commented Mar 21, 2024

Task linked: CU-86drpnxv7 Create a CONTRIBUTING.md file

Copy link
Contributor

@melanke melanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very very good, better than I expected :D

it just need a few fixes

```
2. **Run the Rush Change Command:**

Use the following command, providing a descriptive message of your alterations, and select the appropriate type of modification:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's important to say that if there isn't changes relevant for the users there is no need to add a change message.


## GitHub Actions Workflows

- The [``Check Build and Test``](./.github/workflows/check-build-and-test.yml) workflow runs on every pull request to main branch. This workflow checks if a message was added a message on the change log, checks packages are building, and runs E2E tests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this text is strange

- [PNPM](https://pnpm.io/) as the package manager
- [ESLint](https://eslint.org/) as the linter
- [Prettier](https://prettier.io/) as the code formatter
- [Prettier](https://prettier.io/) as the code formatter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repeated


### Cleaning Rush Js Cash
```bash
rush purge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain why this is necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants