Pinning this library's version #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
separate from the MDS version
Closed
|
No issues from us, we have been using the master builds. The thought here is to decouple mds-provider (the python library) from mds_provider_implementation (the spec). I give this idea a 👍 |
hunterowens
approved these changes
Oct 31, 2018
hunterowens
added a commit
that referenced
this pull request
Nov 13, 2018
…vider * 'master' of https://github.com/CityofSantaMonica/mds-provider: (26 commits) use lowercase for temp table names don't add duplicate columns allow validating from Path instances (#38) Support more Pythonic DBAPI connections (#37) Pinning this library's version (#36) typo fixes for loading data from file quote table names randomize the temp table name (#31) check the initial page before adding improve paging handling (#30) Hacking the associated_trips column into order (#29) expose before_load in shortcut functions guard against non-200 status codes fix to properly handle older versions of providers registry support Path object sources cleaning up a bad copy/rebase fix broken import statement pythonic word choice clean up and some basic logging ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate from the MDS version.
@hunterowens tagging you because this steps the version down from what it was previously "published" as (I was trying to represent the MDS version, not the version of
mds-provider). I don't know if this has implications for your usage of the library.I want to tag releases using semver, so starting from the very beginning seemed logical. But I can always start at
0.2.0if this presents a problem. I think in a system like npm (not sure about pypi) something like this -- releasing an earlier version than the "current" -- isn't allowed; but we aren't there yet with #26, and my processes won't care either way.