Throw exception for unregistered profile #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontub
reviewed
Oct 24, 2023
There was a problem hiding this comment.
RuntimeException might be a more appropriate exception (apart from a custom one).
Would it make sense to throw an exception already in CMRFConnector::load()?
Does the error code have any meaning? If yes, I'd suggest to define it as a constant in some error code class that makes its meaning clear, otherwise I'd drop it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68.
When a CiviMRF profile does not exist but is selected within a CiviMRF connector, there will be PHP warnings (
Warning: Undefined array key "produktivumgebung" in Drupal\cmrf_core\Core->getConnectionProfile() (line 32 of modules/contrib/cmrf_core/src/Core.php).). This throws an exception instead.