Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More war events #2647

Open
wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Conversation

j-gynn
Copy link
Collaborator

@j-gynn j-gynn commented Aug 21, 2024

About The Pull Request

Adds ~20 new war ShortEvents. These primarily cover positive changes to Clan relationship as we've been sorely lacking in those - but it does also add a few new negative ones too! Notably, kit-napping is now a thing, with the chance for kits to be adopted from another Clan or just straight-up abducted with no parent chosen. This also adds a new backstory for these stolen kits since nothing else really fit.

Why This Is Good For ClanGen

Should reduce the frequency of the error message about not being able to find war events.

Proof of Testing

image

Changelog/Credits

Pawsitive war events (sorry lmao)

resources/dicts/events/death/general.json Outdated Show resolved Hide resolved
resources/dicts/events/death/general.json Outdated Show resolved Hide resolved
resources/dicts/events/injury/general.json Show resolved Hide resolved
"season": ["any"],
"sub_type": ["war"],
"weight": 20,
"event_text": "m_c acts without thinking, yanking the o_c_n warrior {PRONOUN/m_c/subject}'d been fighting back from the edge of the cliff and saving their life.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could do with a version of this event in the beach biome, featuring an ocean cliff and roiling waters below.

resources/dicts/events/injury/mountainous.json Outdated Show resolved Hide resolved
resources/dicts/events/misc/general.json Outdated Show resolved Hide resolved
"new_accessory": ["HERBS", "PETALS", "DRY HERBS", "DRY CATMINT", "DRY NETTLES", "DRY LAURELS"],
"sub_type": ["war"],
"weight": 20,
"event_text": "m_c is discovered gambolling along the border with an apprentice from o_c_n! Despite the reminder that the two Clans are far from allies, m_c loudly declares that {PRONOUN/m_c/subject}{VERB/m_c/'re/'s} not giving up {PRONOUN/m_c/poss} friend over some dumb war.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a some_clan negative relationship change might be nice here, I imagine not everyone in the clan would appreciate this app's stance

resources/dicts/events/misc/general.json Show resolved Hide resolved
resources/dicts/events/misc/general.json Show resolved Hide resolved
"can_birth",
"age:has_kits",
"clancat",
"meeting",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, i'm not sure how well this will actually work.. will it actually generate a clancat as an outsider and then handle it correctly? i'm not sure we have the functionality for that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An idea to work around it, make it a loner/rogue with former clancat backstory, one of the ones of leaving the clan and not willing to talk about.

Then players can be like 'oh the cat left their clan to try and reclaim their kits' or some other story of why the parent left the clan in order to get back their kits. /idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants