Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProfileScreen UIWindow bug. #3183

Open
wants to merge 5 commits into
base: release_0.12.0
Choose a base branch
from
Open

Fix ProfileScreen UIWindow bug. #3183

wants to merge 5 commits into from

Conversation

Treefire33
Copy link
Contributor

@Treefire33 Treefire33 commented Dec 15, 2024 •
edited
Loading

About The Pull Request

Prevents the use of keybinds when a window is open on ProfileScreen.
Forces the debug menu to always be on top.

Linked Issues

fixes: #3178

Proof of Testing

https://github.com/user-attachments/assets/6d47248a-4318-4ca4-835b-50ebd8a2a5c0
(Key 27 is Escape)

j-gynn
j-gynn requested changes Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@j-gynn j-gynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to get pressing ESC to close those windows rather than doing nothing? I have a hatred (/lh) of the window_open variable and killed it in the fullscreen rework, so I'd really, really love it if it could continue to Not Exist 😂

@scribblecrumb
Copy link
Collaborator

Additionally, if these issues exist on the stable version, then lets get this targeted at the 0.12.0 branch.

@j-gynn
Copy link
Collaborator

j-gynn commented Dec 16, 2024

Ah - I think the new debug is a development feature, but I don't know about the other bug. If that's present in release 0.12.0, we might want to split this into 2 PRs - one targeting release, one targeting development. Annoying, I know.

@Treefire33 Treefire33 changed the title Fix ProfileScreen UIWindow bug and debug menu layering issue. Fix ProfileScreen UIWindow bug. Dec 20, 2024
@Treefire33
attempt to fix ClanGenOfficial#3178
a0a7bd2 
Disables the ability to keybinds when a window is open.
@Treefire33
Revert "attempt to fix ClanGenOfficial#3178"
b8dc835 
This reverts commit c843159.
@Treefire33
You can use escape again
304e3ab
@Treefire33 Treefire33 changed the base branch from development to release_0.12.0 December 21, 2024 00:00
@Treefire33 Treefire33 mentioned this pull request Dec 21, 2024
Merged
j-gynn
j-gynn requested changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@j-gynn j-gynn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing, I promise! We need to only allow ESC if keybinds are enabled. This is true across all of the windows. Please re-request my review when you've made the changes!

scripts/game_structure/windows.py Outdated Show resolved Hide resolved
@Treefire33 Treefire33 requested a review from j-gynn December 22, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-gynn j-gynn j-gynn requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Keybinds and cat toggles window [DEVBUG] Debug window not always on top
3 participants
@Treefire33 @scribblecrumb @j-gynn