[CLEANUP] Refactoring of python files inside cats, cat_relations, and clan_resoucres folders #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oring not logical. reverting refactoring
…r_death_thought, load_thoughts
j-gynn
requested changes
Dec 25, 2024
| self.thought = final_thought | ||
| return "" | ||
| elif game.clan.leader_lives <= 0: | ||
| if game.clan.leader_lives <= 0: |
There was a problem hiding this comment.
I'm not sure this change won't have unanticipated problems elsewhere in the code, even if it makes sense. There was a change in event code, but I don't recall seeing anything for patrols.
There was a problem hiding this comment.
I redid my refactoring step by step and I feel confident it is working the same way. I might be wrong though
scripts/cat/cats.py
Outdated
| and i not in life_givers | ||
| and self.fetch_cat(i).status not in ["leader", "newborn"] | ||
| ] | ||
| cats_in_starcaln_or_darkforest = game.clan.starclan_cats |
There was a problem hiding this comment.
I am not sure that these lists are regularly updated: to confirm, has this branch been game tested generating leader ceremonies?
There was a problem hiding this comment.
I have tested it by repeatedly killing my leader and promoting a new one, both for Starclan and Dark forest guides and it worked fine. Is there another way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
I have carefully gone though all .py files in the following path and tried to make the code cleaner where i deemed it suitable without changing the intent of the code.
(This is a repost, something severely wrong happened with my fork yesterday and PR #3221 closed)
Why This Is Good For ClanGen
I hope it will help with code readability and therefore maintainability
Linked Issues
Proof of Testing
I've also tested mediate relationships, kill the leader, break up and make mates of cats and other easily triggered events
Changelog/Credits
refactoring and code cleaning in the following folders: