[CODE] refactor medical_cats_condition_fulfilled #3358
+42
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Split
conditions.medical_cats_condition_fulfilled
into two functions,amount_clanmembers_covered
andmedicine_cats_condition_fulfilled
. Updated usages accordingly.Why This Is Good For ClanGen
IMO, it's considered bad practice for a function to be able to return two different things based on arguments it is passed, let alone be capable of returning values of two different types.
In fact, the following Java example will not even compile, because
boolean
is not implicitly convertible toint
in Java:Linked Issues
N/A
Proof of Testing
Changelog/Credits