Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EAGLE-3302] Allow users specify image sizes for image models #149

Merged
merged 6 commits into from
Aug 25, 2023

Conversation

stmugisha
Copy link
Contributor

@stmugisha stmugisha commented Aug 23, 2023

  • Refactor triton config types to match triton serializable types. The existing data type specification using strings started throwing data type mismatch errors at times during the triton model repo generation step. This change helps prevent that.
  • Allow users specify custom height and width dims. (defaults to [-1, -1, 3])

… to suit tritonclient serializable input, hook cli scripts via setup console_scripts
… to suit tritonclient serializable input, hook cli scripts via setup console_scripts
@stmugisha stmugisha changed the base branch from candidate-master to master August 24, 2023 18:01
Copy link
Contributor

@ackizilkale ackizilkale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please make 1024 a variable

@stmugisha stmugisha merged commit 45db102 into master Aug 25, 2023
4 checks passed
@stmugisha stmugisha deleted the EAGLE-3302 branch August 25, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants