Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVX-198]: Fix Dataset import cache bug #167

Merged
merged 1 commit into from
Sep 11, 2023
Merged

[DEVX-198]: Fix Dataset import cache bug #167

merged 1 commit into from
Sep 11, 2023

Conversation

sainivedh
Copy link
Contributor

@sainivedh sainivedh commented Sep 5, 2023 •
edited
Loading

Why

  • Added dynamic import of local dir dataset class, so that users doesn't have to reintialise the class eachtime
from clarifai.client.dataset import Dataset
d.upload_dataset("visual_clf", "train", "module_dir_path")
d.upload_dataset("visual_detection", "train", "module_dir_path")

image

@sainivedh sainivedh marked this pull request as ready for review September 5, 2023 16:59
ackizilkale
ackizilkale approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ackizilkale ackizilkale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sainivedh sainivedh merged commit 8031f53 into master Sep 11, 2023
4 checks passed
@sainivedh sainivedh deleted the DEVX-198-dataset-cache-bug branch September 11, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ackizilkale ackizilkale ackizilkale approved these changes

@sanjaychelliah sanjaychelliah sanjaychelliah approved these changes

@sriram-clarifai sriram-clarifai Awaiting requested review from sriram-clarifai

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sainivedh @ackizilkale @sanjaychelliah