Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Institute model #24

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Add Institute model #24

merged 3 commits into from
Apr 22, 2021

Conversation

frankmangone
Copy link
Member

No description provided.

@frankmangone frankmangone added this to the MVP001 milestone Apr 22, 2021
@frankmangone frankmangone self-assigned this Apr 22, 2021
Copy link
Member

@gastonmorixe gastonmorixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frankmangone LGTM Frank 💯 minor suggestions then you can merge :)

src/entities/institute/institute.resolver.ts Show resolved Hide resolved
src/entities/subject/subject.service.ts Outdated Show resolved Hide resolved
src/schema.gql Outdated Show resolved Hide resolved
@@ -133,16 +161,19 @@ type Mutation {
createCalendar(payload: CreateCalendarInput!): Calendar!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's group these and make a comment like

// Create
...

// Delete

// ...

src/schema.gql Show resolved Hide resolved
@gastonmorixe gastonmorixe changed the title Fm/features/add institute model Add Institute model Apr 22, 2021
@frankmangone frankmangone merged commit a3c3e7b into main Apr 22, 2021
@frankmangone frankmangone deleted the fm/features/add-institute-model branch April 22, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants