-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Targets factories to ease {maldipickr} workflow #46
Conversation
if one uses the {target} factories
BUT issue: targets and tarchetypes have been moved to Imports instead of Suggests
plus a bit of inflated changes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
- Coverage 96.67% 89.40% -7.27%
==========================================
Files 17 20 +3
Lines 541 661 +120
==========================================
+ Hits 523 591 +68
- Misses 18 70 +52 ☔ View full report in Codecov by Sentry. |
this fixes a downstream issue with list structure for `merge_processed_spectra`
inspired by examples in ropensci/jagstargets
This PR includes commits from what should have been a feature branch that I'm struggling to integrate properly. Even if I tried to find non-cherry-pick solutions with merge, I could not get it right: https://devblogs.microsoft.com/oldnewthing/20180323-01/?p=98325 So I'll close, rename the branch and create two proper feature branches: for gather_spectra_stats and targets-factories |
This PR is to draft functions to facilitate reproducible and trustworthy workflow development
{maldipickr}
(using{targets}
).We invite readers unfamiliar with {targets} to read the short and well-written walk-through "How to use {targets}" to understand how {targets} help analysts "coordinate the pieces of computationally demanding analysis projects" and "skips costly runtime for tasks that are already up to date" (source: https://cran.r-project.org/package=targets).
These helpers in
{maldipickr}
are called {targets} factories, which means they return target objects or lists of target objects.