Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Targets factories to ease {maldipickr} workflow #46

Closed
wants to merge 29 commits into from

Conversation

cpauvert
Copy link
Member

@cpauvert cpauvert commented May 6, 2024

This PR is to draft functions to facilitate reproducible and trustworthy workflow development {maldipickr} (using {targets}).

We invite readers unfamiliar with {targets} to read the short and well-written walk-through "How to use {targets}" to understand how {targets} help analysts "coordinate the pieces of computationally demanding analysis projects" and "skips costly runtime for tasks that are already up to date" (source: https://cran.r-project.org/package=targets).

These helpers in {maldipickr} are called {targets} factories, which means they return target objects or lists of target objects.

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 56.66667% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 89.40%. Comparing base (62ecd77) to head (875e2a2).

Files Patch % Lines
R/tar_pick_with_similarity.R 0.00% 52 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   96.67%   89.40%   -7.27%     
==========================================
  Files          17       20       +3     
  Lines         541      661     +120     
==========================================
+ Hits          523      591      +68     
- Misses         18       70      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpauvert cpauvert linked an issue Jun 14, 2024 that may be closed by this pull request
@cpauvert
Copy link
Member Author

This PR includes commits from what should have been a feature branch that I'm struggling to integrate properly. Even if I tried to find non-cherry-pick solutions with merge, I could not get it right: https://devblogs.microsoft.com/oldnewthing/20180323-01/?p=98325 So I'll close, rename the branch and create two proper feature branches: for gather_spectra_stats and targets-factories

@cpauvert cpauvert closed this Sep 12, 2024
@cpauvert cpauvert deleted the targets-factories branch September 12, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add function to gather spectra checks stats
1 participant