Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for DatabaseJanitor #1024

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jjmurre
Copy link

@jjmurre jjmurre commented Sep 26, 2024

The DatabaseJanitor now only accepts keyword arguments.

Chore that needs to be done:

  • Add newsfragment pipenv run towncrier create [issue_number].[type].rst

Types are defined in the pyproject.toml, issue_number either from issue tracker or the Pull request number

The DatabaseJanitor now only accepts keyword arguments.
@fizyk
Copy link
Member

fizyk commented Sep 27, 2024

@jjmurre could you add newsfragment?

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (22944af) to head (5a2ed0f).
Report is 259 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
+ Coverage   95.26%   95.83%   +0.57%     
==========================================
  Files          13       13              
  Lines         401      432      +31     
==========================================
+ Hits          382      414      +32     
+ Misses         19       18       -1     
Flag Coverage Δ
unittests 95.83% <ø> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants