Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirt floors can be constructed on non soil terrain #77875

Open
PatrikLundell opened this issue Nov 15, 2024 · 0 comments
Open

Dirt floors can be constructed on non soil terrain #77875

PatrikLundell opened this issue Nov 15, 2024 · 0 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@PatrikLundell
Copy link
Contributor

Describe the bug

Dirt floors can be constructed on any location where a floor can be constructed, despite it not being a constructed floor, but rather adjustment of pre existing dirt.

Attach save file

Hawaiian Ocean View-trimmed.tar.gz

Steps to reproduce

  1. Walk up the ramp to exit the cellar.
  2. Walk up the ladder at the northern side of the northern shack.
  3. Build a dirt floor on the roof using the construction menu.
  4. See that a dirt floor is now present on the roof.

Expected behavior

Dirt floors should only be possible to make on terrain that's fundamentally soil (i.e. dirt, grass, etc., with the "etc." being up for some debate, due to sand, clay, mud, etc.).

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.5131 (22H2)
  • Game Version: 0.G-13932-gdca38e584e-dirty [64-bit] ("dirty" because it's the code of Remove magic roof addition on manual construction #77873)
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

I tried to address it using the recently introduced ability to have a list of pre terrain in the dirt floor construction definition, but that failed due to this:
DEBUG : get_build_reqs_for_furn_ter_ids tried to get reqs for constr_dirtfloor which has multiple pre_terrain

FUNCTION : operator ()
FILE : C:\Cataclysm-DDA\src\construction.cpp
LINE : 2587
VERSION : 0.G-13932-gdca38e584e-dirty
so it seems a pre terrain list only is supported for the DECORATE category.

@PatrikLundell PatrikLundell added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

1 participant