Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double selection in ImGui uilist menus #78874

Open
Brambor opened this issue Dec 31, 2024 · 3 comments
Open

Double selection in ImGui uilist menus #78874

Brambor opened this issue Dec 31, 2024 · 3 comments
Labels
ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds Info / User Interface Game - player communication, menus, etc. (S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@Brambor
Copy link
Contributor

Brambor commented Dec 31, 2024

Describe the bug

image

Attach save file

N/A

Steps to reproduce

  1. ESC main menu
  2. Observe: there is one selection for mouse and one for keyboard. Expect: 1 in total.

Note, if you carry on:

  1. Select entry with arrow keys.
  2. Hover over an entry with mouse.
  3. Press ENTER (CONFIRM): the entry selected with arrows is chosen, so they really are two separate selections.

Keybindings for uilist:
image

Expected behavior

Only one selection for mouse and keyboard.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.19045.5247 (22H2)
  • Game Version: 0.G-16039-gfc514daf5b [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

No response

@Brambor Brambor added (S1 - Need confirmation) Report waiting on confirmation of reproducibility Info / User Interface Game - player communication, menus, etc. ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds labels Dec 31, 2024
@CLIDragon
Copy link
Contributor

From @db48x in #76373:

I am going to keep the separation between the selected row and the highlighted row, because combining them made people complain and file bug reports. Plus, on menus with descriptions that show up in the footer, or extra information that shows up in a left or right sidebar, it is important that the footer and sidebar be updated based on the hover state, but that the keyboard still be able to override the mouse if the mouse is left hovering over the menu. There are eight or nine menus in the game that have a sidebar, but the most dramatic are the read spell book and spell casting menus from the Magiclysm mod. In the base game the advanced inventory manager will prompt for a location when you move an item out of inventory to the ground if the other column is showing all neighboring tiles rather than a specific one. The rest are mostly debug menus.

@CoroNaut
Copy link

CoroNaut commented Jan 1, 2025

This has been an issue for quite a while, Ive seen it myself in some debug lists. Here's another example: #75661 (comment)

#78755 may remedy most of the occurrences of this issue.

@CLIDragon
Copy link
Contributor

This has been an issue for quite a while, Ive seen it myself in some debug lists. Here's another example: #75661 (comment)

That comment specifically addresses the triple selection, which I thought was fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ImGui Anything related to the new ImGui UI for SDL/tiles or ImTui for curses builds Info / User Interface Game - player communication, menus, etc. (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

3 participants