Added push and pop validation in synchronized block

CleverTap · Oct 29, 2024 · 3d9748f · 3d9748f
1 parent 73dbdca
commit 3d9748f
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/CleverTapSDK/CTValidationResultStack.m b/CleverTapSDK/CTValidationResultStack.m
@@ -41,20 +41,26 @@ - (void)pushValidationResult:(CTValidationResult *)vr {
         CleverTapLogInternal(self.config.logLevel, @"%@: no object in the validation result", self);
         return;
     }
-    [self.pendingValidationResults addObject:vr];
-    if (self.pendingValidationResults && [self.pendingValidationResults count] > 50) {
-        [self.pendingValidationResults removeObjectAtIndex:0];
+
+    @synchronized (self.pendingValidationResults) {
+        [self.pendingValidationResults addObject:vr];
+        if (self.pendingValidationResults.count > 50) {
+            [self.pendingValidationResults removeObjectAtIndex:0];
+        }
     }
 }
 
 - (CTValidationResult *)popValidationResult {
     CTValidationResult *vr = nil;
-    if (self.pendingValidationResults && [self.pendingValidationResults count] > 0) {
-        vr = self.pendingValidationResults[0];
-        [self.pendingValidationResults removeObjectAtIndex:0];
+
+    @synchronized (self.pendingValidationResults) {
+        if (self.pendingValidationResults.count > 0) {
+            vr = self.pendingValidationResults[0];
+            [self.pendingValidationResults removeObjectAtIndex:0];
+        }
     }
+
     return vr;
 }
 
-
 @end