Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-app feature parity #308

Merged
merged 153 commits into from
Jan 15, 2024
Merged

In-app feature parity #308

merged 153 commits into from
Jan 15, 2024

Conversation

nzagorchev
Copy link
Contributor

  • In-apps triggering
  • Client-side in-apps
  • Server-side in-apps
  • Frequency limits
  • Occurrence limits
  • Impressions tracking
  • Triggers tracking
  • Image preloading

nzagorchev and others added 30 commits September 3, 2023 00:30
@nzagorchev
Add InApp Trigger and Limit Adapters and Matchers, ImpressionManager
ffec62a
@nzagorchev
Remove event name from matchCharged
02cd86f
@nzagorchev
Add sample test
69f8832
Added trigger match evaluations and tests
cbb9e62
added charged tests and trigger logic
b5732c7
@nzagorchev
Use ordinal for CTTriggerOperator
155582d
@nzagorchev
Add test for event without props
4c4962d
@nzagorchev
Add TriggerManager
3ddc662
@nzagorchev
Add BatchSentDelegate, implement todos in EvaluationManager
8c32890
added whenlimits and tests
90b0360
Merge branch 'client_side_inapps' of https://github.com/CleverTap/cle…
0fe4605 
…vertap-ios-sdk into client_side_inapps
@nzagorchev
Fix sorting, add tests
5be573a
modified onEvery and onExact limits to use triggers instead of impres…
c7ab2a5 
…sions
@nzagorchev
Refactor CTInAppFCManager WIP
55e7623
@nzagorchev
Merge branch 'client_side_inapps' of github.com:CleverTap/clevertap-i…
215641a 
…os-sdk into client_side_inapps
modified days/weeks whenLimits
b327de3
Merge branch 'client_side_inapps' of https://github.com/CleverTap/cle…
f61a3f5 
…vertap-ios-sdk into client_side_inapps
@nzagorchev
Use excludeGlobalFCaps and efc
f0419ca
@nzagorchev
Refactor CTInAppFCManager WIP 2
9bb1d48
@nzagorchev
Remove dismissedThisSession, fix inAppCounts
00bf4d1
@nzagorchev
Refactor CTInAppFCManager, use current storage keys since legacy are …
4d876c8 
…migrated
added fetchInapps api
b57cb47
added extra checks in trigger matches and unit tests
9c01915
@nzagorchev
Add InApp store
909c99f
@nzagorchev
Evaluate triggers and limits
4fbae8e
added storage methods for inapp store
4bc449e
added encryption test
8f33f29
added plaintext and encryption inapp store getters/setters
f0299f3
@nzagorchev
Attach to batch header using a delegate, EvaluationManager improvements
af948b9
added completion block for fetchInApps
06f316f
nzagorchev and others added 15 commits December 28, 2023 19:43
@nzagorchev
Add delegate manager to InAppStore
e170a54
@nzagorchev
Merge branch 'client_side_inapps' of github.com:CleverTap/clevertap-i…
9453edf 
…os-sdk into feat/SDK-3339/image_preloading
@nishant-clevertap
- Added public api to delete images from disk cache.
1e6f0b4 
- Refactored code changes.
@nzagorchev
Fix InAppStore initialization
3374f5e
@nzagorchev
Make default init unavailable
a3a9437
@nzagorchev
Add unit tests to ensure delegates are added and behave correctly
ae5409a
@nzagorchev
Fix inactive image assets and add tests
5ad2406
@nzagorchev
Remove impressions and triggers for stale inapps
adaa0bc
@nzagorchev
Merge branch 'client_side_inapps' of github.com:CleverTap/clevertap-i…
5a55506 
…os-sdk into feat/SDK-3339/image_preloading

# Conflicts:
#	CleverTapSDK.xcodeproj/project.pbxproj
#	CleverTapSDK/CleverTap.m
#	CleverTapSDK/InApps/CTInAppStore.h
#	CleverTapSDKTests/InApps/CTInAppFCManagerTest.m
@nzagorchev
Fix update of last deleted ts and ensure cleanup ts is expired
d1ed8fd
@nishant-clevertap
Updated storing image assets with accountID only
4165624
@nishant-clevertap
Merge pull request #307 from CleverTap/feat/SDK-3339/image_preloading
ad8b4bb 
SDK-3339 Image Preloading
@nishant-clevertap
feat(inApps): Add display condition for HTML in-apps to prevent showi…
b51e3a0 
…ng when there is no network.
@nishant-clevertap
Used deviceInfo class to check network is reachable or not.
fe6e84a
@nzagorchev
Add isOnline to DeviceInfo and use it in HTML template
ee82d94
@nzagorchev nzagorchev changed the base branch from master to develop January 11, 2024 08:11
@nzagorchev nzagorchev marked this pull request as ready for review January 15, 2024 08:12
@nzagorchev nzagorchev merged commit 8e8f05c into develop Jan 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashvercetti akashvercetti akashvercetti approved these changes

@nishant-clevertap nishant-clevertap Awaiting requested review from nishant-clevertap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nzagorchev @akashvercetti @nishant-clevertap