Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set netcdf_output_at_levels default to true #2908

Merged
merged 3 commits into from
Apr 17, 2024
Merged

set netcdf_output_at_levels default to true #2908

merged 3 commits into from
Apr 17, 2024

Conversation

szy21
Copy link
Member

@szy21 szy21 commented Apr 16, 2024

Purpose

Even though the z coordinate in the netcdf output is not correct, I think this is more useful for debugging as we can see the data on the raw levels. I kept one with netcdf_output_at_levels: false in ci to make sure it works.

To-do

Content


  • I have read and checked the items on the review checklist.

@szy21 szy21 requested a review from Sbozzolo April 16, 2024 21:02
@akshaysridhar
Copy link
Member

I think this is perhaps fine for the CI plots since the design intent is to use ClimaAnalysis to generate the correct warped surface levels as a post-processing step. cc @Sbozzolo

@Sbozzolo
Copy link
Member

Tests passing, feel free to merge

@szy21 szy21 added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit 826b85e Apr 17, 2024
9 of 11 checks passed
@szy21 szy21 deleted the zs/netcdf_rawlevel branch April 17, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants