Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for plots of time-varying spectra #3036

Merged
merged 1 commit into from
May 23, 2024
Merged

Add support for plots of time-varying spectra #3036

merged 1 commit into from
May 23, 2024

Conversation

Sbozzolo
Copy link
Member

With this PR, compute_spectrum can now take a time-varying OutputVar and return a time-varying spectrum.

It also changes the default to log-log plots for spectra.

@akshaysridhar
Copy link
Member

Is this feature exercised in buildkite now (can you link a relevant build id / test problem) ? (Buildkite runs appear to be the only tests for this within ClimaAtmos - is this correct?)

akshaysridhar
akshaysridhar reviewed May 23, 2024
View reviewed changes
Copy link
Member

@akshaysridhar akshaysridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Once the buildkite outcome is verified we can merge this PR.

@Sbozzolo Sbozzolo enabled auto-merge May 23, 2024 18:09
akshaysridhar
akshaysridhar approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@akshaysridhar akshaysridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the buildkite update.

We can clean up the plot title strings in ClimaAnalysis but the ClimaAtmos component with user defined averaging windows is fine.

@akshaysridhar akshaysridhar mentioned this pull request May 23, 2024
Closed
@Sbozzolo Sbozzolo added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit eba9f0c May 23, 2024
11 checks passed
@Sbozzolo Sbozzolo deleted the gb/spectra_diag branch May 23, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaysridhar akshaysridhar akshaysridhar approved these changes

@dennisYatunin dennisYatunin Awaiting requested review from dennisYatunin

@szy21 szy21 Awaiting requested review from szy21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sbozzolo @akshaysridhar