Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYAMOND Summer low-resolution simulation #3458

Merged
merged 4 commits into from
Dec 18, 2024
Merged

DYAMOND Summer low-resolution simulation #3458

merged 4 commits into from
Dec 18, 2024

Conversation

sriharshakandala
Copy link
Member

@sriharshakandala sriharshakandala commented Nov 26, 2024 •
edited
Loading

Purpose

Add DYAMOND Summer low-resolution simulation.

To-do

Content

  • I have read and checked the items on the review checklist.

@sriharshakandala sriharshakandala marked this pull request as draft November 26, 2024 18:51
@sriharshakandala sriharshakandala changed the title Initial conditions from file (rough draft, work-in-progress) Initial conditions from file Nov 26, 2024
@sriharshakandala sriharshakandala force-pushed the sk/dyamond_summer_ics branch 3 times, most recently from 9471246 to f63259b Compare November 26, 2024 19:54
szy21
szy21 reviewed Nov 26, 2024
View reviewed changes
src/solver/type_getters.jl Outdated Show resolved Hide resolved
@sriharshakandala sriharshakandala changed the title Initial conditions from file DYAMOND Summer low-resolution simulation Nov 27, 2024
@sriharshakandala sriharshakandala changed the title DYAMOND Summer low-resolution simulation DYAMOND Summer low-resolution simulation Nov 27, 2024
szy21
szy21 reviewed Nov 30, 2024
View reviewed changes
src/solver/type_getters.jl Outdated Show resolved Hide resolved
szy21
szy21 reviewed Dec 12, 2024
View reviewed changes
src/solver/type_getters.jl Outdated Show resolved Hide resolved
szy21
szy21 reviewed Dec 12, 2024
View reviewed changes
src/solver/type_getters.jl Outdated Show resolved Hide resolved
@sriharshakandala sriharshakandala force-pushed the sk/dyamond_summer_ics branch 3 times, most recently from 9241853 to fbfedb7 Compare December 12, 2024 23:41
@sriharshakandala sriharshakandala marked this pull request as ready for review December 12, 2024 23:43
Sbozzolo
Sbozzolo reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@Sbozzolo Sbozzolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add documentation before we start looking at the code?

Sbozzolo
Sbozzolo reviewed Dec 13, 2024
View reviewed changes
src/initial_conditions/initial_conditions.jl Outdated Show resolved Hide resolved
src/initial_conditions/initial_conditions.jl Show resolved Hide resolved
src/initial_conditions/initial_conditions.jl Outdated Show resolved Hide resolved
src/initial_conditions/initial_conditions.jl Outdated Show resolved Hide resolved
src/solver/type_getters.jl Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
config/gpu_configs/gpu_aquaplanet_dyamond_summer.yml Show resolved Hide resolved
src/utils/AtmosArtifacts.jl Outdated Show resolved Hide resolved
@Sbozzolo Sbozzolo force-pushed the sk/dyamond_summer_ics branch from fe9bea7 to 4e18b58 Compare December 16, 2024 20:30
@Sbozzolo Sbozzolo force-pushed the sk/dyamond_summer_ics branch 4 times, most recently from ed05ac4 to a2bf121 Compare December 16, 2024 23:08
@Sbozzolo Sbozzolo force-pushed the sk/dyamond_summer_ics branch from a2bf121 to 7499907 Compare December 17, 2024 02:08
sriharshakandala and others added 2 commits December 16, 2024 18:09
@sriharshakandala @Sbozzolo
Add DYAMONDSummer low resolution simulation.
ce87270 
Provides a method that overwrites initial conditions in instances
where initial values are assigned from existing datasets.
@Sbozzolo
Address review
d75e96a 
	modified:   NEWS.md
@Sbozzolo Sbozzolo force-pushed the sk/dyamond_summer_ics branch from 7499907 to bfb346d Compare December 17, 2024 02:09
@Sbozzolo Sbozzolo force-pushed the sk/dyamond_summer_ics branch from bfb346d to eaa2f8c Compare December 17, 2024 02:10
@Sbozzolo
Copy link
Member

I updated this so that we can read any file with a given format, not just the dyamond case.

@Sbozzolo Sbozzolo enabled auto-merge December 17, 2024 02:11
@Sbozzolo
Add Flat conditions to ozone
356222e 
Data is only available until 2014
@Sbozzolo Sbozzolo force-pushed the sk/dyamond_summer_ics branch from 7a74e10 to 356222e Compare December 17, 2024 18:50
@Sbozzolo Sbozzolo added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 7d472f2 Dec 18, 2024
16 checks passed
@Sbozzolo Sbozzolo deleted the sk/dyamond_summer_ics branch December 18, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaysridhar akshaysridhar akshaysridhar left review comments

@szy21 szy21 szy21 left review comments

@Sbozzolo Sbozzolo Sbozzolo left review comments

@dennisYatunin dennisYatunin Awaiting requested review from dennisYatunin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sriharshakandala @Sbozzolo @szy21 @akshaysridhar