Add float-type constructor for ClimaAtmosParameters #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nefrathenrici
force-pushed
the
ne/params
branch
3 times, most recently
from
9ffa61c to
0d1cb44
Compare
Sbozzolo
reviewed
Dec 18, 2024
nefrathenrici
force-pushed
the
ne/params
branch
from
0d1cb44 to
c2d164d
Compare
Sbozzolo
approved these changes
Dec 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
charleskawczynski
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to create a minimal parameter set for all model configurations using FT as input.
create_parameter_sethas been replaced with directClimaAtmosParametersconstructors which are not dependent on the AtmosConfig, but we should not see any simulation changes.ClimaAtmosParameters (CAP) now contains parameters for all configurations to prevent the use of parsed_args. CAP already contained parameters that were unused by certain configurations, such as RRTMGP parameters. This primarily affects the microphysics parameters - both 0m and 1m params are now stored regardless of config. This PR touches a lot of files because the access to specific microphysics parameters structs in tendencies had to be changed.
The main method is
ClimaAtmosParameters(toml_dict::TD, dt = nothing). Ifdtis passed in, it is used to override theprecipitation_timescaleused in microphysics. Since the config keyoverride_precip_timescaleis no longer used it has been removed.Other constructors are available, which end up calling the toml_dict method:
ClimaAtmosParameters(config::AtmosConfig)ClimaAtmosParameters(::Type{FT}, dt = nothing)This PR also removes water_params, they are unused