Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add particulate remineralization according to profile (e.g. Martin Curve). #19

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

seamanticscience
Copy link
Collaborator

Purpose

Adding some fundamental processes to our simple ocean carbon cycle model:

  1. Iron is complexed by organic ligands according to an equilibrium reaction (e.g. Parekh et al., 2005; 2006)
  2. Sinking organic particles are remineralized according to a prescribed profile shape, such as a power law or exponential (e.g. Cael & Bisson, 2018; Lauderdale & Cael, 2021)

To-do

  • introduce a simpler 2-D example
  • check it runs correctly/efficiently

@glwagner
Copy link
Member

glwagner commented Oct 4, 2023

Do we want to keep adding baroclinic_adjustment_with_*, or should we just have one example that runs more than one case? Eventually we will want to build examples along with documentation, at that point each example will be somewhat expensive (they are also expensive to maintain)

@glwagner
Copy link
Member

glwagner commented Oct 4, 2023

Let me know when you'd like me to read the code carefully!

@seamanticscience
Copy link
Collaborator Author

Do we want to keep adding baroclinic_adjustment_with_*, or should we just have one example that runs more than one case? Eventually we will want to build examples along with documentation, at that point each example will be somewhat expensive (they are also expensive to maintain)

Fair enough, that was just the example I was working with (#18 ) so I carried on.

@glwagner
Copy link
Member

glwagner commented Oct 5, 2023

Do we want to keep adding baroclinic_adjustment_with_*, or should we just have one example that runs more than one case? Eventually we will want to build examples along with documentation, at that point each example will be somewhat expensive (they are also expensive to maintain)

Fair enough, that was just the example I was working with (#18 ) so I carried on.

Feel free to reject my idea!

@seamanticscience
Copy link
Collaborator Author

I'm thinking "ocean_wind_mixing_and_convection" might be good eventually since it has T and S for carbonate chemistry calculations and winds for CO2 fluxes!

@glwagner
Copy link
Member

glwagner commented Oct 5, 2023

Also there is more value added if we come up with new physics rather than simply replicating something already in Oceananigans. I can help.

The narrow range of Oceananigans examples isn't because we don't have ideas, it's because we can only afford so many experiments due to their high cost.

Copy link
Collaborator

@emilyzakem emilyzakem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one you wanted me to review/approve, right, Jon?

@seamanticscience seamanticscience marked this pull request as draft November 14, 2023 19:11
@seamanticscience
Copy link
Collaborator Author

I think we (@seamanticscience, @glwagner, and @emilyzakem) decided that it's not going to be super valuable to implement prescribed profile-dependent remineralization right now: the code is really slow, and there is a robust alternative using biogeochemical_drift_velocity. However I don't want to lose any progress, or preclude revisiting this at a later date, so I'm converting this to a draft. I split out the iron chemistry to a new P/R #23.

@seamanticscience seamanticscience changed the title Add iron loss by scavenging and particulate remineralization according to profile (e.g. Martin Curve). Add particulate remineralization according to profile (e.g. Martin Curve). Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants