-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add particulate remineralization according to profile (e.g. Martin Curve). #19
base: main
Are you sure you want to change the base?
Conversation
…ile (e.g. power law)
Do we want to keep adding |
Let me know when you'd like me to read the code carefully! |
Fair enough, that was just the example I was working with (#18 ) so I carried on. |
Feel free to reject my idea! |
I'm thinking "ocean_wind_mixing_and_convection" might be good eventually since it has T and S for carbonate chemistry calculations and winds for CO2 fluxes! |
Also there is more value added if we come up with new physics rather than simply replicating something already in Oceananigans. I can help. The narrow range of Oceananigans examples isn't because we don't have ideas, it's because we can only afford so many experiments due to their high cost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the one you wanted me to review/approve, right, Jon?
I think we (@seamanticscience, @glwagner, and @emilyzakem) decided that it's not going to be super valuable to implement prescribed profile-dependent remineralization right now: the code is really slow, and there is a robust alternative using |
Purpose
Adding some fundamental processes to our simple ocean carbon cycle model:
To-do