ci: fix docker build

ClickAndMortar · May 3, 2024 · f3e41df · f3e41df
1 parent 7019687
commit f3e41df
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/.github/workflows/docker.yaml b/.github/workflows/docker.yaml
@@ -24,17 +24,14 @@ jobs:
           node-version: 18
           registry-url: 'https://registry.npmjs.org/'
 
-      - name: Install dependencies
-        run: npm install
-
       - name: Login to Docker Hub
         uses: docker/login-action@v1
         with:
           username: ${{ secrets.DOCKER_USERNAME }}
           password: ${{ secrets.DOCKER_PASSWORD }}
 
       - name: Build and push Docker image
-        uses: docker/build-push-action@v2
+        uses: docker/build-push-action@v5
         with:
           context: .
           file: ./Dockerfile
@@ -44,6 +41,8 @@ jobs:
             clickandmortar/mage-wizard:${{ github.sha }}
             clickandmortar/mage-wizard:latest
           platforms: linux/amd64,linux/arm64
+          build-args: |
+            DOCKER_BUILDKIT=1
 
       - name: Clean up Buildx
         uses: docker/build-push-action@v2

diff --git a/Dockerfile b/Dockerfile
@@ -4,8 +4,7 @@ WORKDIR /app
 
 COPY . /app
 
-# npm install is ran in the builder stage, to avoid GitHub actions failure
-RUN npm run build
+RUN npm install && npm run build
 
 
 FROM node:18-alpine