Merge pull request #18 from ClickHouse/upd_1.11.234

Update to 1.11.234

.cspell.json

@@ -11,7 +11,7 @@
         "Bodyless", "HTTPGET", "ratelimiter", "Ratelimiter", "STDMETHODCALLTYPE", "CANTSAVE", "OLECHAR", "DISPID",
         "UNKNOWNNAME", "DISPPARAMS", "XMLHTTP", "comptr", "Metadataservice", "Streamfn", "HWAVEOUT", "matdesc",
         "Presigner", "xindex", "errortype", "waveout", "WAVEOUTCAPSA", "ALLOWSYNC", "WAVEHDR", "MMSYSERR",
-        "WAVEFORMATEX", "Unprepare", "DDISABLE_IMDSV1",
+        "WAVEFORMATEX", "Unprepare", "DDISABLE_IMDSV1", "threadpool",
         // AWS general
         "Arns", "AMZN", "amzn", "Paulo", "Ningxia", "ISOB", "isob", "AWSXML", "IMDSV",
         // AWS Signature
@@ -22,7 +22,7 @@
         "PythonInterp", "DWAVE", "Winmm", "DPULSE", "pulseaudio", "MSVC", "NOTFOUND", "libpulse", "COREAUDIO",
         "devel", "AUDIOTOOLBOX", "DCORE", "CONCAT", "DNON", "FULLPATCH", "setopt", "CURLOPT", "SSLCERT",
         "CROSSCOMPILING", "nullptr", "DWORD", "lpsz", "commoncrypto", "COMMONCRYPTO", "endforeach", "pkgconfig",
-        "MGMT", "DENABLED",
+        "MGMT", "DENABLED", "DENFORCE",
         // Compiler and linker
         "Wpedantic", "Wextra", "Werror", "xldscope", "Wtype", "Wunused", "RTTI", "ffunction", "fdata", "fsanitize",
         "pathconf", "unistd", "umask", "GNUCXX", "libasan", "SUNPRO", "gnustl", "libgnustl", "Wmissing",
@@ -59,7 +59,9 @@
         // Aws common runtime libraries
         "mqtt",
         // Aws common runtime API
-        "Mtls"
+        "Mtls",
+	    // Opentelemetry
+	    "Otel", "opentelemetry", "nostd", "OPTEL", "tparam","OTLP"
     ],
     "ignoreWords": [
         // variables defined in ConcurrentStreamBuf

.github/workflows/handle-stale-discussions.yml

@@ -0,0 +1,18 @@
+name: HandleStaleDiscussions
+on:
+  schedule:
+    - cron: '0 */4 * * *'
+  discussion_comment:
+    types: [created]
+
+jobs:
+  handle-stale-discussions:
+    name: Handle stale discussions
+    runs-on: ubuntu-latest
+    permissions:
+      discussions: write
+    steps:
+      - name: Stale discussions action
+        uses: aws-github-ops/handle-stale-discussions@v1
+        env:
+          GITHUB_TOKEN:  ${{secrets.GITHUB_TOKEN}}

.github/workflows/stale_issue.yml

@@ -14,7 +14,7 @@ jobs:
       with:
         # Setting messages to an empty string will cause the automation to skip
         # that category
-        ancient-issue-message: Greetings! Sorry to say but this is a very old issue that is probably not getting as much attention as it deservers. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.
+        ancient-issue-message: Greetings! Sorry to say but this is a very old issue that is probably not getting as much attention as it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.
         stale-issue-message: Greetings! It looks like this issue hasn’t been active in longer than a week. We encourage you to check if this is still an issue in the latest release. Because it has been longer than a week since the last update on this, and in the absence of more information, we will be closing this issue soon. If you find that this is still a problem, please feel free to provide a comment or add an upvote to prevent automatic closure, or if the issue is already closed, please feel free to open a new one.
         stale-pr-message: Greetings! It looks like this PR hasn’t been active in longer than a week, add a comment or an upvote to prevent automatic closure, or if the issue is already closed, please feel free to open a new one.
 
@@ -32,7 +32,7 @@ jobs:
         # Issue timing
         days-before-stale: 2
         days-before-close: 5
-        days-before-ancient: 365
+        days-before-ancient: 36500
 
         # If you don't want to mark a issue as being ancient based on a
         # threshold of "upvotes", you can set this here. An "upvote" is

.github/workflows/time-blocker.yml

@@ -0,0 +1,16 @@
+name: Block Merge During Daily Release
+on:
+  pull_request:
+    branches: [ main ]
+  merge_group:
+    branches: [ main ]
+jobs:
+  block:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: yykamei/[email protected]
+        with:
+          timezone: "UTC"
+          after: 18:00
+          before: 20:00
+          base-branches: "main"

.gitignore

@@ -10,6 +10,7 @@ Release
 *#
 *.iml
 tags
+.vscode
 
 # CI Artifacts
 BuildSpec.json

CMakeLists.txt

@@ -62,6 +62,11 @@ if (LEGACY_BUILD)
     option(ENABLE_ZLIB_REQUEST_COMPRESSION "For services that support it, request content will be compressed. On by default if dependency available" ON)
     option(DISABLE_INTERNAL_IMDSV1_CALLS "Disables IMDSv1 internal client calls" OFF)
     option(BUILD_BENCHMARKS "Enables building the benchmark executable" OFF)
+    option(BUILD_OPTEL "Enables building the open telemetry implementation of tracing" OFF)
+    option(AWS_SDK_WARNINGS_ARE_ERRORS "Compiler warning is treated as an error. Try turning this off when observing errors on a new or uncommon compiler" ON)
+    option(BUILD_OPTEL_OTLP_BENCHMARKS "Enables building the benchmark tests with open telemetry OTLP clients" OFF)
+    option(USE_TLS_V1_2 "Set http client to enforce TLS 1.2" ON)
+    option(USE_TLS_V1_3 "Set http client to enforce TLS 1.3" OFF)
 
     set(AWS_USER_AGENT_CUSTOMIZATION "" CACHE STRING "User agent extension")
     set(AWS_TEST_REGION "US_EAST_1" CACHE STRING "Region to target integration tests against")
@@ -76,6 +81,12 @@ if (LEGACY_BUILD)
     if (DISABLE_INTERNAL_IMDSV1_CALLS)
         add_definitions(-DDISABLE_IMDSV1)
     endif ()
+    if (USE_TLS_V1_2)
+        add_definitions(-DENFORCE_TLS_V1_2)
+    endif ()
+    if (USE_TLS_V1_3)
+        add_definitions(-DENFORCE_TLS_V1_3)
+    endif ()
 
     #From https://stackoverflow.com/questions/18968979/how-to-get-colorized-output-with-cmake
     if (NOT WIN32)

README.md

@@ -4,47 +4,12 @@ The AWS SDK for C++ provides a modern C++ (version C++ 11 or later) interface fo
 AWS SDK for C++ is in now in General Availability and recommended for production use. We invite our customers to join
 the development efforts by submitting pull requests and sending us feedback and ideas via GitHub Issues.
 
-## Version 1.11 is now Available!
-
-This release introduces a refactored Asynchronous API and restructures the File Hierarchy of the project source code. Additionally, the minimum required version of cmake was raised to 3.13.
-* Asynchronous API refactoring is a partially breaking, backward incompatible change: all client methods such as OperationAsync and OperationCallable are no longer virtual methods but instead are conditionally compiled template methods. Having these methods as templates reduces the total binary size of the SDK by 40%. Individual client binary size may vary. In addition, it reduces build time of the SDK by up to 50% (release, unity build, SDK clients only).
-  A code change may be required if your code inherits SDK’s Client classes and overrides the virtual async methods. Regular synchronous/blocking call methods are still available for override.
-  Code changes are not required and SDK API are backward compatible if virtual async methods were not overwritten before.
-* Scripts and IDE project files not using the provided cmake build infrastructure must be reviewed and updated to reflect source tree changes.
-
-All CRT libraries are git submodules of SDK for C++. It requires changes in git syntax to get all source code.
-* New users: If you haven't downloaded the source code for SDK for C++, you can get all git submodules recursively by:
-   ```
-   git clone --recurse-submodules https://github.com/aws/aws-sdk-cpp
-   ```
-* Existing users: If you’ve already downloaded source code for SDK for C++, e.g. in directory `aws-sdk-cpp`, you can update the git submodule by:
-   ```
-   cd aws-sdk-cpp
-   git checkout main
-   git pull origin main
-   git submodule update --init --recursive
-   ```
-* Alternatively, if you downloaded the code bundle from GitHub website and have no installation of git, you can download all the dependencies running the `prefetch_crt_dependency.sh` script from the root of the repository. It will download bundles of all dependencies from github website using curl and expand them in the right locations.
-
-
-See Wiki page [Improving S3 Throughput with AWS SDK for CPP v1.9](https://github.com/aws/aws-sdk-cpp/wiki/Improving-S3-Throughput-with-AWS-SDK-for-CPP-v1.9) for more details, and create a new [issue](https://github.com/aws/aws-sdk-cpp/issues/new/choose) or [pull request](https://github.com/aws/aws-sdk-cpp/compare) if you have any feedback on this new version.
-
-## API Reference Docs
-
-The AWS SDK C++ recently re-formatted their API docs to be more modularized for easier navigation. Please update any old bookmarks that you may have.
-
-The root index of the documents can be found at https://sdk.amazonaws.com/cpp/api/LATEST/index.html
-
-from here each service specific documentation can be found under the `modules` tab. Upon opening one of these, you will see the associated class list of the client, including a links to the `core` module.
-
-## Upgrade Your SDK to Get Latest Security Patches
-The AWS SDK for C++ has a dependency on cJSON. This dependency was updated to version 1.7.14 in the recent SDK updates. We would recommend to upgrade your SDK to version 1.9.67 for 1.9.x or 1.8.187 for 1.8.x. Thank @dkalinowski for reporting this issue: https://github.com/aws/aws-sdk-cpp/issues/1594
-
-__Jump To:__
-* [Getting Started](#Getting-Started)
-* [Issues and Contributions](#issues-and-contributions)
-* [Getting Help](#Getting-Help)
-* [Using the SDK and Other Topics](#Using-the-SDK-and-Other-Topics)
+## __Jump To:__
+* [Change log](https://github.com/aws/aws-sdk-cpp/tags)
+* [API Docs](https://sdk.amazonaws.com/cpp/api/LATEST/index.html)
+* [Getting Started](#getting-started)
+* [Getting Help](#getting-help)
+* [Using the SDK and Other Topics](#using-the-sdk-and-other-topics)
 
 # Getting Started
 
@@ -54,43 +19,46 @@ __Jump To:__
 * Visual Studio 2015 or later
 * OR GNU Compiler Collection (GCC) 4.9 or later
 * OR Clang 3.3 or later
-* 4GB of RAM
-  * 4GB of RAM is required to build some of the larger clients. The SDK build may fail on EC2 instance types t2.micro, t2.small and other small instance types due to insufficient memory.
+* 4GB of RAM (This is required to build some of the larger clients. The SDK build may fail on EC2 instance types t2.micro, t2.small and other small instance types due to insufficient memory)
+* Supported platforms
+  * Amazon Linux
+  * Windows
+  * Mac
 
 ### Building From Source:
 
 #### To create an **out-of-source build**:
 1. Install CMake and the relevant build tools for your platform. Ensure these are available in your executable path.
-2. Create your build directory. Replace <BUILD_DIR> with your build directory name:
+2. Clone this repository with submodules
 
-3. Build the project:
+    ```sh
+    git clone --recurse-submodules https://github.com/aws/aws-sdk-cpp
+    ```
 
-   * For Auto Make build systems:
-   ```sh
-   cd <BUILD_DIR>
-   cmake <path-to-root-of-this-source-code> -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH=<path-to-install>
-   make
-   make install
-   ```
+3. Create your build directory. Replace <BUILD_DIR> with your build directory name:
+4. Build the project:
 
-   * For Visual Studio:
-   ```sh
+    ```sh
    cd <BUILD_DIR>
-   cmake <path-to-root-of-this-source-code> -G "Visual Studio 15 Win64" -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH=<path-to-install>
-   msbuild ALL_BUILD.vcxproj /p:Configuration=Debug
+   cmake <path-to-root-of-this-source-code> \
+    -DCMAKE_BUILD_TYPE=Debug \
+    -DCMAKE_INSTALL_PREFIX=<path-to-install> \
+    -DBUILD_ONLY="s3"
+   cmake --build . --config=Debug
+   cmake --install . --config=Debug
    ```
 
-   * For macOS - Xcode:
-   ```sh
-   cmake <path-to-root-of-this-source-code> -G Xcode -DTARGET_ARCH="APPLE" -DCMAKE_BUILD_TYPE=Debug -DCMAKE_PREFIX_PATH=<path-to-install>
-   xcodebuild -target ALL_BUILD
-   ```
+   **_NOTE:_** BUILD_ONLY is an optional flag used to list only the services you are using. Building the whole sdk can take a long time. Also check out the list of [CMake parameters](./docs/CMake_Parameters.md)
+
 #### Other Dependencies:
 To compile in Linux, you must have the header files for libcurl, libopenssl. The packages are typically available in your package manager.
 
-Debian example:
+Debian based Linux distributions example:
    `sudo apt-get install libcurl-dev`
 
+RPM based Linux distributions example:
+   `sudo [yum|dnf|zypper] install libcurl-devel`
+
 ### Building for Android
 To build for Android, add `-DTARGET_ARCH=ANDROID` to your cmake command line. Currently we support Android APIs from 19 to 28 with Android NDK 19c and we are using build-in cmake toolchain file supplied by Android NDK, assuming you have the appropriate environment variables (ANDROID_NDK) set.
 
@@ -107,16 +75,17 @@ Nmake builds targets in a serial fashion.  To make things quicker, we recommend
    cmake -G "NMake Makefiles JOM" `-DTARGET_ARCH=ANDROID` <other options> ..
    ```
 
-### Building for Docker
-
-To build for Docker, ensure your container meets the [minimum requirements](#minimum-requirements). By default, Docker Desktop is set to use 2 GB runtime memory. We have provided [Dockerfiles](https://github.com/aws/aws-sdk-cpp/tree/master/CI/docker-file) as templates for building the SDK in a container.
+### Building aws-sdk-cpp - Using vcpkg
 
+You can download and install aws-sdk-cpp using the [vcpkg](https://github.com/Microsoft/vcpkg) dependency manager:
 
-### Building and running an app on EC2
-Checkout this walk through on how to set up an environment and build the [AWS SDK for C++ on an EC2 instance](https://github.com/aws/aws-sdk-cpp/wiki/Building-the-SDK-from-source-on-EC2).
+    git clone https://github.com/Microsoft/vcpkg.git
+    cd vcpkg
+    ./bootstrap-vcpkg.sh
+    ./vcpkg integrate install
+    ./vcpkg install aws-sdk-cpp
 
-# Issues and Contributions
-We welcome all kinds of contributions, check [this guideline](./CONTRIBUTING.md) to learn how you can contribute or report issues.
+The aws-sdk-cpp port in vcpkg is kept up to date by Microsoft team members and community contributors. If the version is out of date, please [create an issue or pull request](https://github.com/Microsoft/vcpkg) on the vcpkg repository.
 
 # Maintenance and support for SDK major versions
 
@@ -128,26 +97,31 @@ For information about maintenance and support for SDK major versions and our und
 
 # Getting Help
 
-The best way to interact with our team is through GitHub. You can [open an issue](https://github.com/aws/aws-sdk-cpp/issues/new/choose) and choose from one of our templates for guidance, bug reports, or feature requests.
+The best way to interact with our team is through GitHub. You can open a [discussion](https://github.com/aws/aws-sdk-cpp/discussions/new/choose) for guidance questions or an [issue](https://github.com/aws/aws-sdk-cpp/issues/new/choose) for bug reports or feature requests.
 
 You may also find help on community resources such as [StackOverFlow](https://stackoverflow.com/) with the tag [#aws-sdk-cpp](https://stackoverflow.com/questions/tagged/aws-sdk-cpp). If you have a support plan with [AWS Support](https://aws.amazon.com/premiumsupport/), you can also create a new support case.
 
 Please make sure to check out our resources too before opening an issue:
-* Our [Developer Guide](https://docs.aws.amazon.com/sdk-for-cpp/v1/developer-guide/welcome.html) and [API reference](http://sdk.amazonaws.com/cpp/api/LATEST/index.html)
-* Our [Changelog](./CHANGELOG.md) for recent breaking changes.
-* Our [Contribute](./CONTRIBUTING.md) guide.
-* Our [samples repo](https://github.com/awsdocs/aws-doc-sdk-examples/tree/master/cpp).
+* [Developer Guide](https://docs.aws.amazon.com/sdk-for-cpp/v1/developer-guide/welcome.html) and [API reference](http://sdk.amazonaws.com/cpp/api/LATEST/index.html)
+* [Changelog](./CHANGELOG.md) for recent breaking changes.
+* [Contribution](./CONTRIBUTING.md) guide.
+* [samples repo](https://github.com/awsdocs/aws-doc-sdk-examples/tree/master/cpp).
 
 
 # Using the SDK and Other Topics
-* [Using the SDK](./docs/SDK_usage_guide.md)
-* [CMake Parameters](./docs/CMake_Parameters.md)
-* [Credentials Providers](./docs/Credentials_Providers.md)
-* [Client Configuration Parameters](./docs/ClientConfiguration_Parameters.md)
-* [Service Client](./docs/Service_Client.md)
-* [Memory Management](./docs/Memory_Management.md)
-* [Advanced Topics](./docs/Advanced_topics.md)
-* [Add as CMake external project](./docs/CMake_External_Project.md)
+* Other docs for how to build the sdk
+  * [CMake Parameters](./docs/CMake_Parameters.md)
+  * [Add as CMake external project](./docs/CMake_External_Project.md)
+  * [Builing for Docker](https://github.com/aws/aws-sdk-cpp/tree/master/CI/docker-file) (To build for Docker, ensure your container meets the [minimum requirements](#minimum-requirements))
+  * [Building on an EC2 instance](https://github.com/aws/aws-sdk-cpp/wiki/Building-the-SDK-from-source-on-EC2)
+* SDK usage
+  * [API Docs](https://sdk.amazonaws.com/cpp/api/LATEST/index.html)
+  * [Using the SDK](./docs/SDK_usage_guide.md)
+  * [Credentials Providers](./docs/Credentials_Providers.md)
+  * [Client Configuration Parameters](./docs/ClientConfiguration_Parameters.md)
+  * [Service Client](./docs/Service_Client.md)
+  * [Memory Management](./docs/Memory_Management.md)
+  * [Advanced Topics](./docs/Advanced_topics.md)
 * [Coding Standards](./docs/CODING_STANDARDS.md)
 * [License](./LICENSE)
 * [Code of Conduct](./CODE_OF_CONDUCT.md)

VERSION

@@ -1 +1 @@
-1.11.61
+1.11.234

cmake/AWSSDKConfig.cmake

@@ -24,7 +24,6 @@ if(AWSSDK_FOUND)
     return()
 endif()
 
-include(${CMAKE_CURRENT_LIST_DIR}/AWSSDKConfigVersion.cmake)
 include(${CMAKE_CURRENT_LIST_DIR}/sdksCommon.cmake)
 include(${CMAKE_CURRENT_LIST_DIR}/platformDeps.cmake)
 include(${CMAKE_CURRENT_LIST_DIR}/compiler_settings.cmake)
@@ -99,14 +98,18 @@ if (NOT AWSSDK_CORE_HEADER_FILE)
     message(FATAL_ERROR "AWS SDK for C++ is missing, please install it first")
 endif()
 
-# based on core header file path, inspects the actual AWSSDK_ROOT_DIR
-get_filename_component(AWSSDK_ROOT_DIR "${AWSSDK_CORE_HEADER_FILE}" PATH)
-get_filename_component(AWSSDK_ROOT_DIR "${AWSSDK_ROOT_DIR}" PATH)
-get_filename_component(AWSSDK_ROOT_DIR "${AWSSDK_ROOT_DIR}" PATH)
-get_filename_component(AWSSDK_ROOT_DIR "${AWSSDK_ROOT_DIR}" PATH)
-
-if (NOT AWSSDK_ROOT_DIR)
-    message(FATAL_ERROR "AWSSDK_ROOT_DIR is not set or can't be calculated from the path of core header file")
+if (IS_ABSOLUTE ${AWSSDK_INSTALL_LIBDIR})
+    set(AWSSDK_ROOT_DIR "")
+else()
+    # based on core header file path, inspects the actual AWSSDK_ROOT_DIR
+    get_filename_component(AWSSDK_ROOT_DIR "${AWSSDK_CORE_HEADER_FILE}" PATH)
+    get_filename_component(AWSSDK_ROOT_DIR "${AWSSDK_ROOT_DIR}" PATH)
+    get_filename_component(AWSSDK_ROOT_DIR "${AWSSDK_ROOT_DIR}" PATH)
+    get_filename_component(AWSSDK_ROOT_DIR "${AWSSDK_ROOT_DIR}" PATH)
+
+    if (NOT AWSSDK_ROOT_DIR)
+        message(FATAL_ERROR "AWSSDK_ROOT_DIR is not set or can't be calculated from the path of core header file")
+    endif()
 endif()
 
 
@@ -162,7 +165,7 @@ if (AWSSDK_ADDITIONAL_LIBS)
     set(AWSSDK_PLATFORM_DEPS "${AWSSDK_PLATFORM_DEPS}" "${AWSSDK_ADDITIONAL_LIBS}")
 endif()
 
-message(STATUS "Found AWS SDK for C++, Version: ${PACKAGE_VERSION}, Install Root:${AWSSDK_ROOT_DIR}, Platform Prefix:${AWSSDK_PLATFORM_PREFIX}, Platform Dependent Libraries: ${AWSSDK_PLATFORM_DEPS}")
+message(STATUS "Found AWS SDK for C++, Version: ${AWSSDK_VERSION}, Install Root:${AWSSDK_ROOT_DIR}, Platform Prefix:${AWSSDK_PLATFORM_PREFIX}, Platform Dependent Libraries: ${AWSSDK_PLATFORM_DEPS}")
 
 
 # copy libs of services in SERVICE_LIST and all there dependent libs to DEST_DIR

cmake/build_external.cmake

@@ -131,7 +131,7 @@ if(BUILD_CURL OR BUILD_OPENSSL OR BUILD_ZLIB)
         -DEXTERNAL_CXX_FLAGS=${EXTERNAL_CXX_FLAGS}
         -DEXTERNAL_C_FLAGS=${EXTERNAL_C_FLAGS}
         -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
-        ${CMAKE_CURRENT_SOURCE_DIR}/android-build
+        ${CMAKE_CURRENT_SOURCE_DIR}/tools/android-build
         WORKING_DIRECTORY ${EXTERNAL_BUILD_DIR}
         RESULT_VARIABLE CONFIGURE_DEPS_EXIT_CODE)