Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes from feedback 7/9. #84

Closed
Tracked by #1
sanchegm opened this issue Jul 18, 2024 · 4 comments · Fixed by #101
Closed
Tracked by #1

Make changes from feedback 7/9. #84

sanchegm opened this issue Jul 18, 2024 · 4 comments · Fixed by #101

Comments

@sanchegm
Copy link
Collaborator

sanchegm commented Jul 18, 2024

Requested changes from 07/09 meeting:

  • Name: has official long name, official short name. We will need to accommodate both names.

  • Coordinator - usually 1-3 people

    • Each coordinator name will need to be mapped to a specific email.
  • Status

    • Should be a dropdown/select value
    • Active, Applying, Inactive, Retired
    • There is some discrepancy if Inactive and Retired are both needed as there was some changes recently. Stanford ClinGen to check with greater team about terms used.
  • Family

  • Type

    • Should be a dropdown/select value
    • Options:
      • Variant Curation Expert Panel (VCEP)
      • Gene Curation Expert Panel (GCEP)
      • Independent Curation Group
  • Legacy ID value for older 10000

    • Rachel to raise on agenda on the july 24
  • Members

    • These values hsould be view only. can only be edited in the VCI/GCI
    • Need to get update from API
@sanchegm
Copy link
Collaborator Author

Rachel to no longer present about ID changes. On 07/24 meeting, Matt and Liam decided to keep the existing system based on external meeting held where 10000 number ID is used by other teams.

@sanchegm
Copy link
Collaborator Author

ID functionality will be worked on in this issue: #73

@sanchegm
Copy link
Collaborator Author

Communicating with the GPM API to get members values will be worked on in this issue: #102

@sanchegm
Copy link
Collaborator Author

Will PR 101, all requested updates from the feedback meeting have been made. With the exception of the ID system and Members API communication, which have their own independent issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant