Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add selects and dropdown values #98

Merged
merged 2 commits into from
Jul 24, 2024
Merged

feat: add selects and dropdown values #98

merged 2 commits into from
Jul 24, 2024

Conversation

sanchegm
Copy link
Collaborator

Description

  • Add Select/Dropdown choices and functionality for status, type and CDWG.
  • CDWG can be "None" for external/independant working groups
  • Abbreviated name can be null if no shortened name is available.

Issue Ticket Number and Link

Related to Issue #84

Checklist

Remove any options that are not applicable

[X ] I have reviewed the how-to guide and the contributing file.

[X] I have run required code checks and resolved any blockers.

[X] I have created the necessary tests to show my changes are effective and work as intended.

[X] I have thoroughly commented my code, especially in more complex areas.

[X] I have updated any necessary documentation.

Screenshots / Recordings
Edit an affiliation, open Status select
Screenshot 2024-07-24 at 1 47 26 PM

Edit an affiliation, open Type select
Screenshot 2024-07-24 at 1 47 31 PM

Edit an affiliation, open CDWG select
Screenshot 2024-07-24 at 1 47 35 PM

- abbreviated name can be null
- add in selects/dropdown values for status, type, and CDWG
@sanchegm sanchegm changed the title Gs 84 dropdown feat: add selects and dropdown values Jul 24, 2024
@sanchegm sanchegm marked this pull request as ready for review July 24, 2024 20:52
@sanchegm sanchegm requested a review from liammulh July 24, 2024 20:52
Copy link
Member

@liammulh liammulh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍🏻

@sanchegm sanchegm merged commit ba32f65 into main Jul 24, 2024
4 checks passed
@sanchegm sanchegm deleted the gs-84-dropdown branch July 24, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants