-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mito QC stats JSON conversion crash for bam started-runs when BAM-derived sample id deviates from rerun sample id #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just some small reflections.
bin/mito_tsv_to_json.py
Outdated
args = parser.parse_args() | ||
|
||
|
||
def extract_value_by_suffix(row: dict, key_suffix: str) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dict[str, str]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope. the python3 in our wgs singularity container is too old for that.
typing.Dict
might work though. i'll check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could try this:
https://peps.python.org/pep-0585/
I.e. importing
from __future__ import annotations
And then
dict[str, str]
Not sure it works. But curious to know
Script confirmed to work for commit 844ae20:
|
Scrpt confirmed to work for commit 844ae20 in wgs trio. |
I'm omitting scout testing here, as this part of the pipeline does not affect scout loads. I've confirmed that the QC data for CDM is a merged parseable json for both wgs single and trio. |
The update resolves one particular obstacle in bam-started pipeline runs, but there is work remaining that will have to be resolved in a separate patch: #233 |
Description and reviewer info
Update to process and python script that converts mito sentieon coverage TSV to JSON.
The script previously required sample-id input to properly access specific fields in the TSV.
This has now been changed so that the same values are accessed by suffix, under the strong
assumption that the TSV contains data from only one sample.
Fixes #169
Type of change
Checklist
Verification_samples_log
Excel sheetMinor change / patch-ish
Test/review documentation
Review performed by
(Add if missing)
Testing performed by