-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verifybamid2 #243
Add verifybamid2 #243
Conversation
…o separate between panel and wgs samples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 💪 Just some minor points and questions.
Don't forget to add the version to the version document.
I would like to take a final quick look before merge when updated.
Looks nice! But please add the version to the version document before merge (that is part of the same repo, so it is just to change that |
The version document is now updated with verifybamid2! |
Great! I don't see it in the PR here though. Have you forgotten to push the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, looks nice now!
So, remember before merge:
- Tag the last commit "v3.11.1"
- Document testing you have made (I think you ran a panel? and also put it into the "Verification samples log" spreadsheet)
Description and reviewer info
Add a verifybamid2 process with a if clause to separate between wgs and panel data input. In addition the data used by the verifybamid2 software and container has been added to the config.
Type of change
Checklist
Verification_samples_log
Excel sheetDocumentation
Patch
Major / Minor change
onco
run finishes without any new warnings/errors and the results canbe loaded into scout
wgs
single run finishes without any new warnings/errors and the resultscan be loaded into scout
wgs
trio run finishes without any new warnings/errors and the resultscan be loaded into scout
Test/review documentation
Review performed by
(Add if missing)
Testing performed by