Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SVDB to 2.8.2 #245

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Update SVDB to 2.8.2 #245

wants to merge 14 commits into from

Conversation

alkc
Copy link
Contributor

@alkc alkc commented Oct 28, 2024

Description and reviewer info

Adds:

  • SVDB container

Updates:

  • SVDB from 2.2.0 to 2.8.2

Changes:

Closes #118, fixes #244, fixes #216

TODO:

  • Put post-processing perl script calls in separate process
    • svdb_merge
    • svdb_merge panel
  • Complete onco run w/ svdb 2.8.2
  • Complete wgs run w/ svdb 2.8.2
  • Set up test plan
    • Diff a few SV VCFs and see what diffs
    • How major of a validation do we need to do?
  • (Bonus) move remaining container specs into config

Type of change

  • Documentation
  • Patch
  • Minor change
  • Major change

Checklist

  • Self-review of my code
  • Update the CHANGELOG
  • Tag the latest commit (vX.Y.Z format)
  • Log samples used for testing in the Verification_samples_log Excel sheet

Documentation

  • At least one other person has reviewed my changes (not required for trivial changes)

Patch

  • Stub run completes without errors or new warnings
  • At least one other person has reviewed and approved my code (not required for trivial changes)

Major / Minor change

  • Stub run completes without errors or new warnings
  • onco run finishes without any new warnings/errors and the results can
    be loaded into scout
  • wgs single run finishes without any new warnings/errors and the results
    can be loaded into scout
  • wgs trio run finishes without any new warnings/errors and the results
    can be loaded into scout
  • At least one other person has reviewed and approved my code
  • I have made corresponding changes to the documentation (software versions, etc.)

Test/review documentation

Review performed by

  • Alexander
  • Jakob
  • Paul
  • Ryan
  • Viktor

(Add if missing)

Testing performed by

  • Alexander
  • Jakob
  • Paul
  • Ryan
  • Viktor

@alkc alkc marked this pull request as draft October 28, 2024 14:04
@alkc alkc changed the title Update SVDB to 4.8.2 Update SVDB to 2.8.2 Oct 28, 2024
@alkc
Copy link
Contributor Author

alkc commented Oct 29, 2024

Using an SVDB container from galaxy proj. those do not seem to have perl installed. the follow up merge_callset perl script calls need to be moved to own process, or - if no other special dependencies - converted to python.

the order in which input VCFs are supplied to svdb merge affects rank scores through loqusdb artefat matching

this change ensures that input svvcfs are sorted on filename before the input to svdb merge is constructed
the cnvkit_panel container has previously been set to twistmyeloid_active.sif
which has been pointing to twistmyeloid_2020-06-17 since
2024-06-24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant