Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @s command target #2129

Merged
merged 1 commit into from
Jun 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/cn/nukkit/command/defaults/BanCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)
return false;
}

String name = args[0];
String name = args[0].replace("@s", sender.getName());
StringBuilder reason = new StringBuilder();
for (int i = 1; i < args.length; i++) {
reason.append(args[i]).append(" ");
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/cn/nukkit/command/defaults/DeopCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)
return false;
}

String playerName = args[0];
String playerName = args[0].replace("@s", sender.getName());
IPlayer player = sender.getServer().getOfflinePlayer(playerName);
player.setOp(false);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)
sender.sendMessage(new TranslationContainer("commands.generic.usage", this.usageMessage));
return true;
}
Player player = sender.getServer().getPlayer(args[0]);
Player player = sender.getServer().getPlayer(args[0].replace("@s", sender.getName()));
if (player == null) {
sender.sendMessage(new TranslationContainer(TextFormat.RED + "%commands.generic.player.notFound"));
return true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)
sender.sendMessage(new TranslationContainer("commands.generic.usage", this.usageMessage));
return true;
}
Player player = sender.getServer().getPlayer(args[0]);
Player player = sender.getServer().getPlayer(args[0].replace("@s", sender.getName()));
if (player == null) {
sender.sendMessage(new TranslationContainer(TextFormat.RED + "%commands.generic.player.notFound"));
return true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)
CommandSender target = sender;
if (args.length > 1) {
if (sender.hasPermission("nukkit.command.gamemode.other")) {
target = sender.getServer().getPlayer(args[1]);
target = sender.getServer().getPlayer(args[1].replace("@s", sender.getName()));
if (target == null) {
sender.sendMessage(new TranslationContainer(TextFormat.RED + "%commands.generic.player.notFound"));
return true;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/cn/nukkit/command/defaults/GiveCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)
return true;
}

Player player = sender.getServer().getPlayer(args[0]);
Player player = sender.getServer().getPlayer(args[0].replace("@s", sender.getName()));
Item item;

try {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/cn/nukkit/command/defaults/KickCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)
return false;
}

String name = args[0];
String name = args[0].replace("@s", sender.getName());

StringBuilder reason = new StringBuilder();
for (int i = 1; i < args.length; i++) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/cn/nukkit/command/defaults/KillCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)
sender.sendMessage(new TranslationContainer(TextFormat.RED + "%commands.generic.permission"));
return true;
}
Player player = sender.getServer().getPlayer(args[0]);
Player player = sender.getServer().getPlayer(args[0].replace("@s", sender.getName()));
if (player != null) {
if (player.isCreative() || player.isSpectator()) {
sender.sendMessage(TextFormat.RED + "No targets matched selector");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)
return true;
}
} else {
target = sender.getServer().getPlayer(args[0]);
target = sender.getServer().getPlayer(args[0].replace("@s", sender.getName()));
if (target == null) {
sender.sendMessage(new TranslationContainer(TextFormat.RED + "%commands.generic.player.notFound"));
return true;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/cn/nukkit/command/defaults/TellCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)
return false;
}

String name = args[0].toLowerCase();
String name = args[0].replace("@s", sender.getName());

Player player = sender.getServer().getPlayer(name);
if (player == null) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/cn/nukkit/command/defaults/TitleCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)
return false;
}

Player player = Server.getInstance().getPlayerExact(args[0]);
Player player = Server.getInstance().getPlayerExact(args[0].replace("@s", sender.getName()));
if (player == null) {
sender.sendMessage(new TranslationContainer(TextFormat.RED + "%commands.generic.player.notFound"));
return true;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/cn/nukkit/command/defaults/XpCommand.java
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public boolean execute(CommandSender sender, String commandLabel, String[] args)
player = (Player) sender;
} else if (args.length == 2) {
amountString = args[0];
playerName = args[1];
playerName = args[1].replace("@s", sender.getName());
player = sender.getServer().getPlayer(playerName);
} else {
sender.sendMessage(new TranslationContainer("commands.generic.usage", this.usageMessage));
Expand Down