[FLOC-2543] Continue on volume errors #1768
Open
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return original_attach_volume(blockdevice_id, attach_to) | ||
|
|
||
| self.patch(api, 'attach_volume', fake_attach_volume) | ||
| changes = in_parallel([change1, change2]) |
There was a problem hiding this comment.
Note that "in_parallel" does a sort internally, so maybe disable the sorting and see if that causes breakage?
|
Unless that change manages to reproduce it, as discussed I suggest closing this and the issue and seeing if it ever happens again, since we can't figure it out. |
|
Can someone verify this PR? |
|
This PR has been around for a while. Maybe we should close it for now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design for https://clusterhq.atlassian.net/browse/FLOC-2643
I wrote a test that attempts to attach two loopback block devices but raises an exception during the first attachment.
Unfortunately, this test passes.
I need to look harder at the code and think about a better way to simulate the 'openstack volume in "error" state situation.'