Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance completion at non-interactive mode #1391

Merged

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Apr 17, 2024

Related issue #1390

'id=' completion

# crm configure primitive id=

property completion

# crm configure property 
batch-limit=                join-finalization-timeout=  pe-error-series-max=        stonith-enabled=
cluster-delay=              join-integration-timeout=   pe-input-series-max=        stonith-max-attempts=
cluster-ipc-limit=          load-threshold=             pe-warn-series-max=         stonith-timeout=
cluster-name=               maintenance-mode=           placement-strategy=         stonith-watchdog-timeout=
cluster-recheck-interval=   migration-limit=            priority-fencing-delay=     stop-all-resources=
concurrent-fencing=         node-action-limit=          remove-after-stop=          stop-orphan-actions=
dc-deadtime=                node-health-base=           shutdown-escalation=        stop-orphan-resources=
election-timeout=           node-health-green=          shutdown-lock=              symmetric-cluster=
enable-acl=                 node-health-red=            shutdown-lock-limit=        transition-delay=
enable-startup-probes=      node-health-strategy=       start-failure-is-fatal=     
fence-reaction=             node-health-yellow=         startup-fencing=            
have-watchdog=              no-quorum-policy=           stonith-action=

Otherwise, non-interactive commands like `crm configure property` will
not produce completion results.
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.33%. Comparing base (1b89f20) to head (f48cda5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1391   +/-   ##
=======================================
  Coverage   53.33%   53.33%           
=======================================
  Files          80       80           
  Lines       23942    23942           
=======================================
  Hits        12769    12769           
  Misses      11173    11173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 changed the title Enhance completion Enhance completion at non-interactive mode Apr 17, 2024
@liangxin1300 liangxin1300 requested a review from zzhou1 April 17, 2024 09:55
@liangxin1300 liangxin1300 merged commit 6ec5681 into ClusterLabs:master Apr 29, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants