Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crmsh-4.6] Dev: bootstrap: Skip ssh-agent warning when cluster is running #1638

Open
wants to merge 1 commit into
base: crmsh-4.6
Choose a base branch
from
Open

[crmsh-4.6] Dev: bootstrap: Skip ssh-agent warning when cluster is running #1638

wants to merge 1 commit into from

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Dec 19, 2024 •
edited
Loading

backport #1630

@liangxin1300
Dev: bootstrap: Skip ssh-agent warning when cluster is running
c8d8f78 
Since at this time the ssh stage has finished, we can skip the warning
@liangxin1300 liangxin1300 marked this pull request as ready for review December 19, 2024 14:37
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.03%. Comparing base (a6a2678) to head (c8d8f78).

Additional details and impacted files
Flag Coverage Δ
integration 52.68% <100.00%> (-0.06%) ⬇️
unit 49.64% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/bootstrap.py 84.63% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasyang2022 nicholasyang2022 Awaiting requested review from nicholasyang2022

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liangxin1300