Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.6] Dev: help: Support '--help' option for cluster properties #1648

Conversation

liangxin1300
Copy link
Collaborator

backport #1643

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.

Project coverage is 66.91%. Comparing base (9fab03a) to head (96869dc).
Report is 11 commits behind head on crmsh-4.6.

Files with missing lines Patch % Lines
crmsh/help.py 38.46% 8 Missing ⚠️
crmsh/ui_configure.py 33.33% 2 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 52.68% <61.53%> (+<0.01%) ⬆️
unit 49.46% <14.81%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/command.py 60.50% <100.00%> (+1.03%) ⬆️
crmsh/ui_configure.py 45.55% <33.33%> (-0.05%) ⬇️
crmsh/help.py 84.02% <38.46%> (-2.03%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…710)

By using `crm configure property <property> --help`, print the help of
property on non-interactive mode.
To mention if no property is specified, all properties will be printed.
Also, add a note to mention that use --help to print help text for each
property.
@liangxin1300 liangxin1300 force-pushed the 20241225_cluster_property_crmsh46 branch from ba10b29 to 96869dc Compare December 31, 2024 08:32
@liangxin1300 liangxin1300 requested a review from zzhou1 December 31, 2024 08:36
@liangxin1300 liangxin1300 marked this pull request as ready for review December 31, 2024 08:36
@liangxin1300 liangxin1300 merged commit 06e1195 into ClusterLabs:crmsh-4.6 Jan 2, 2025
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants