Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some findings:
A general consequence of this would be to prefer to return int-only codes (instead of a class with code + optional message), at least for performance critical calls. Otherwise, it should be evaluated on per-case basis.
The documented benchmarks were done with a million iterations.
I expect iOS to be much quicker, as it shouldn't do any serialization / deserialization. Without the JSON based api, of course.