Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ruby-macho version to be greater than or equal to 1, less than 3 #10396

Closed
wants to merge 32 commits into from
Closed

Conversation

PeqNP
Copy link

@PeqNP PeqNP commented Feb 1, 2021

This PR refers to this discussion #10390

In short, some xcframeworks are failing to be parsed by the ruby-macho dependency. Version 2.x (5?) fixes this issue. The result is that dependencies will not be considered a valid dynamic library and have a corresponding install_framework command added to the project's respective frameworks bash script.

@PeqNP PeqNP changed the title Set ruby-macho version to be greater than 1, less than 3 Set ruby-macho version to be greater than or equal to 1, less than 3 Feb 1, 2021
@PeqNP
Copy link
Author

PeqNP commented Feb 1, 2021

I'm pretty sure I know why 2.3 is failing. I believe ruby-macho needs ruby version 2.4 or higher to build. I believe I saw that error when I was attempting to install this dependency with 2.3.8 on macOS. I believe 2.3 isn't supported either.

@PeqNP
Copy link
Author

PeqNP commented Feb 1, 2021

@dnkoutso dnkoutso added this to the 1.11.0 milestone Feb 1, 2021
@dnkoutso
Copy link
Contributor

dnkoutso commented Feb 1, 2021

I believe there is a pR up to bump cocoapods to use Ruby 2.6?

@dnkoutso
Copy link
Contributor

dnkoutso commented Feb 1, 2021

See CocoaPods/Core#671

@igor-makarov
Copy link
Contributor

@dnkoutso there's no Ruby deprecation PR yet for CocoaPods, but it's coming in the near future.

segiddins and others added 21 commits February 5, 2021 16:29
… opening a CocoaPods workspace for the first time
…ojects

Ensure that Xcode does not need to re-serialize projects/schemes when…
Rewrite the only place dependent on `typhoeus`
Respect `--configuration` option when analyzing via `pod lib lint --analyze`
Fix typo in method documentation
@dnkoutso
Copy link
Contributor

dnkoutso commented Jul 2, 2021

@PeqNP this should now be unblocked if you rebase. We bumped min version to >= Ruby 2.6.

@PeqNP
Copy link
Author

PeqNP commented Jul 2, 2021

Should be good now 🌈

@igor-makarov
Copy link
Contributor

Looks like the rebase contains many existing commits, mind dropping them?

@PeqNP
Copy link
Author

PeqNP commented Jul 2, 2021

Hm. I have no idea what I'm doing. I haven't done a rebase in years to another remote. At this point I may as well create another PR and try again. I'm not sure how to back out of the current state. I'm not sure when I'm going to have time to figure this out either.

@dnkoutso
Copy link
Contributor

dnkoutso commented Jul 5, 2021

For #10390

@dnkoutso
Copy link
Contributor

dnkoutso commented Jul 5, 2021

@PeqNP i will take over this.

@dnkoutso
Copy link
Contributor

dnkoutso commented Jul 5, 2021

Closing in favor of #10762

@dnkoutso dnkoutso closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.