You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
go get github.com/ethereum/go-ethereum/rlp will download whole source code of go-ethereum.
The codes are saved in $GOPATH/pkg/github.com/ethereum/go-ethereum.
And when I import only rlp like 5cea778#diff-b22bd1d77f068190b14a8488f1e7c21b, golang only includes rlp package while compiling.
My point is, is this really could be a problem? I think downloading only rlp folder to the $GOPATH looks odder.
Thanks for explaining how the import is working.
Although other parts of Go Ethereum code is not compiled, downloading a huge code base that is not used is a problem.
@gurrpi You can try this issue.
We don't know how the Golang import is working.
So we are not confident that using Go-Ethereum's rlp package is good or bad.
IMO importing a small package in a big repository is not a recommended practice. Because a user that using CodeChain Go SDK may download the big repository to use the library.
Do you know the Golang users' convention about using a small package in a big repository?
We are importing the whole Go Ethereum code to use the RLP code.
We should import only the RLP code.
The text was updated successfully, but these errors were encountered: