Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hex string types #12

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Add hex string types #12

merged 1 commit into from
Oct 10, 2019

Conversation

cubismic
Copy link
Member

output go test in ./primitives is

[0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
true
false

[144 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0]
0x00000000000000000000000000000000
PASS
ok      github.com/CodeChain-io/codechain-rpc-go/primitives     0.005s

@cubismic cubismic requested a review from majecty October 10, 2019 05:57
@@ -1,3 +1,5 @@
module github.com/CodeChain-io/codechain-rpc-go

go 1.12

require github.com/ethereum/go-ethereum v1.9.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go ethereum is a very huge project.
Can't we import just the rlp package?

Copy link
Member Author

@cubismic cubismic Oct 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking for importing only rlp package but it is hard to find.

I did
go get github.com/ethereum/go-ethereum/rlp
but go mod includes every go-ethereum...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Let's fix it later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added issue #13.

@cubismic cubismic merged commit 5cea778 into CodeChain-io:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants