Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import, duplicate and delete themes #1718

Merged

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented May 14, 2024

Description

Improves theme settings UI. Adds the ability to import, duplicate, and delete themes. Persisting changes to theme file.

Related Issues

Checklist

  • Improved theme settings UI
  • Improved theme details UI
  • Import theme
  • Duplicate theme
  • Delete theme
  • Edit and Delete are disabled for bundled themes
  • Persist changes to theme file
  • Iterator appended to theme name when there is a naming conflict upon rename, duplicate, and import
  • Preserve property order in cetheme file on save
  • Hide duplicate button when importing or duplicating
  • When importing or duplicating, Cancel button deletes theme
  • When file is modified externally, reload themes to reflect changes (will do later)
  • Theme import file validation (will do later)

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-06-18.at.2.22.08.PM.mp4

@danielzsh
Copy link
Contributor

Will this do essentially what CodeEditApp/CodeEditSourceEditor#245 was trying to? If yes, I'll close my PR then 😅

@austincondiff
Copy link
Collaborator Author

@danielzsh Not really but we will probably need to adjust font weights in CESE in order for this to work, so we can address it all then. We really appreciate the effort, but go ahead and close it for now.

@austincondiff austincondiff changed the title Theme token formatting Ability to import, duplicate and delete themes Jun 17, 2024
@austincondiff austincondiff force-pushed the 1717-theme-token-formatting branch from ed69437 to a107a34 Compare June 18, 2024 04:40
@austincondiff austincondiff marked this pull request as ready for review June 18, 2024 18:50
@austincondiff austincondiff changed the title Ability to import, duplicate and delete themes Import, duplicate and delete themes Jun 22, 2024
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! Awesome work

Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, misclicked my approval. It still looks perfect, just one small thing.

@austincondiff austincondiff force-pushed the 1717-theme-token-formatting branch from 87b199e to 225521a Compare June 24, 2024 20:06
Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting thing and a suggestion

@thecoolwinter
Copy link
Collaborator

I did also notice there's some serious delay when updating the theme. I tracked this back to the fact that the themes are being saved every time a color is updated. We should throttle the saving action in the future, I'll make an issue for it.

@thecoolwinter
Copy link
Collaborator

Updated so the theme is updated in real time as it's edited (if it's the currently selected one) and the selected theme appearance defaults to the app's current color when opening the themes tab (eg if on light mode it shows the light mode ones first).

Screen.Recording.2024-06-26.at.10.03.26.AM.mov

@austincondiff austincondiff merged commit 4ac87ee into CodeEditApp:main Jun 26, 2024
2 checks passed
@thecoolwinter thecoolwinter added the enhancement New feature or request label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants