Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP Document Content Sync #1887

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Sep 17, 2024

Description

Note

Requires #1879 to be merged, based on that branch. This will look like it's a massive change until that is merged.
Requires CodeEditApp/CodeEditSourceEditor#265 to be merged as it provides the required APIs to make this work.

Changes:

  • Implements Language Server document content syncing.
  • Adds a LSPContentCoordinator which manages forwarding content change notifications to the correct language server.
  • The language server has been updated to send the correct document sync notifications depending on what the language server supports.

Misc related changes:

  • Fixed bugs with the cursor position label, uses the tab change subject instead of a variety of notification sources. Also split it into two views for ease in maintenance.
  • Fixed a bug where a temporary tab replacing an existing temporary tab did not have it's file opened by the editor manager.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter marked this pull request as draft September 17, 2024 21:16
@thecoolwinter thecoolwinter added the language server Issues or Pull Requests related to language servers. label Sep 18, 2024
@thecoolwinter thecoolwinter marked this pull request as ready for review September 27, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language server Issues or Pull Requests related to language servers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants