Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Tabs Closing Wrong Tab, Terminal Right Click Semantics #1963

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Jan 7, 2025

Description

  • Fixes a bug where the wrong terminal tab would be removed when deleting a tab.
  • Updates the right-click menu to show "Kill Terminals" when the action would kill multiple terminals. Also updates the tab list to work as expected (right clicking an element of a large selection performs the action on the entire selection, otherwise, just the item that was clicked).
  • Fixes an issue where the utility area was covered in the accessibility inspector.
  • Wrote tests for the utility area view model.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2025-01-08.at.12.00.18.AM.mov

Screenshot 2025-01-07 at 11 33 30 PM

@thecoolwinter thecoolwinter marked this pull request as draft January 7, 2025 16:57
@thecoolwinter thecoolwinter changed the title Terminal Tabs Closing Wrong Tab, Right Click Menu Update Terminal Tabs Closing Wrong Tab, Terminal Right Click Semantics Jan 8, 2025
@thecoolwinter thecoolwinter marked this pull request as ready for review January 8, 2025 05:31
@thecoolwinter thecoolwinter added bug Something isn't working tests labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Utility Area is Not Accessible
2 participants