Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Editor (powered by tree-sitter) #662

Merged
merged 2 commits into from
Jun 11, 2022

Conversation

lukepistrol
Copy link
Member

@lukepistrol lukepistrol commented Jun 11, 2022

Description

To keep development simple and up-to-date we should push the new editor to the main branch.

This is the same content as in feature/new-editor branch.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • I documented my code
  • Review requested

Screenshots

Screen Shot 2022-06-11 at 15 47 05

Copy link
Member

@lilingxi01 lilingxi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM. How does it look like right now?

@0xWDG
Copy link
Collaborator

0xWDG commented Jun 11, 2022

@lilingxi01 updated description

@wdg it will eventually highlight but Swift takes some time to resolve the queries. This is a known issue.

Both issues are not related to this PR but more related to CodeEditTextView.

Please create an issue there.

Done 😊
CodeEditApp/CodeEditTextView#20
CodeEditApp/CodeEditTextView#21

@lukepistrol
Copy link
Member Author

lukepistrol commented Jun 11, 2022

@lilingxi01 updated description

@wdg it will eventually highlight but Swift takes some time to resolve the queries. This is a known issue.

Both issues are not related to this PR but more related to CodeEditTextView.

Please create an issue there.

@lukepistrol lukepistrol merged commit e40500a into CodeEditApp:main Jun 11, 2022
@lukepistrol lukepistrol deleted the feat/new-editor branch June 11, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request source editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants