Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Configuration to toggle line numbers visibility #115

Open
vitalyster opened this issue Jan 13, 2023 · 10 comments
Open

✨ Configuration to toggle line numbers visibility #115

vitalyster opened this issue Jan 13, 2023 · 10 comments
Labels
enhancement New feature or request

Comments

@vitalyster
Copy link

Is your feature request related to a problem? Please describe.

Line numbers make UI bloated, we have line indicator in status bar

Describe the solution you'd like

Please hide line numbers by default

Describe alternatives you've considered

At least there should be an option to hide

Additional context

Screenshot 2023-01-13 at 03 52 24

@vitalyster vitalyster added the enhancement New feature or request label Jan 13, 2023
@lukepistrol lukepistrol transferred this issue from CodeEditApp/CodeEdit Jan 13, 2023
@lukepistrol
Copy link
Member

We probably won't hide the line numbers by default but having an option to turn them off seems like a good idea 👍

@thecoolwinter thecoolwinter changed the title Line numbers ✨Option To Hide Line Numbers Jan 13, 2023
@ben-p-commits
Copy link
Contributor

@lukepistrol - I'll take this one on.

@austincondiff
Copy link
Collaborator

Should we provide the ability to hide line numbers or hide the entire gutter which includes indications for code folding, code review, etc.? Maybe both (could be too much though)?

@ben-p-commits
Copy link
Contributor

Anecdotal- but I believe people who ditch line numbers are probably good with eschewing folding, review- etc.

@ben-p-commits
Copy link
Contributor

image

then again...

xcode goes all the way

image

@ben-p-commits
Copy link
Contributor

ben-p-commits commented Jan 23, 2023

@austincondiff, perhaps we add the options as separate enhancements when the respective functionality is implemented?

Hard to say whether the RulerView is going to be the container for those future features like a code ribbon, or if sibling views are needed for them.

@austincondiff
Copy link
Collaborator

I like that. If Xcode provides the ability to show/hide each thing individually, we should do the same.

@ben-p-commits
Copy link
Contributor

ben-p-commits commented Jan 23, 2023

@austincondiff, So- do we wait for those features to be implemented? 😆

@ben-p-commits
Copy link
Contributor

@austincondiff
Copy link
Collaborator

@ben-p-commits No, just making a comment that we should hide just the line numbers here and the others as they get implemented. 😉

@austincondiff austincondiff changed the title ✨Option To Hide Line Numbers ✨ Option To Hide Line Numbers Feb 16, 2023
@austincondiff austincondiff changed the title ✨ Option To Hide Line Numbers ✨ Configuration to toggle line numbers visibility Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🚧 Blocked
Development

No branches or pull requests

4 participants