Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly Lose Focus (finish CETV#14) #229

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

thecoolwinter
Copy link
Collaborator

Description

Finishes the required changes to make CodeEditTextView#14 work in CESE, once those changes are merged with a package update.

Removes the first responder acquisition when updating cursors, the text view should handle focus state and does so correctly on the main branch. Also fixes a small ordering bug with a check variable related to this issue.

Related Issues

  • CodeEditTextView issue, no issues created here.

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
You probably know this, but you can use the trailing closure syntax on the sorted method.

Copy link
Collaborator

@0xWDG 0xWDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoolwinter
Copy link
Collaborator Author

LGTM! You probably know this, but you can use the trailing closure syntax on the sorted method.

Oh, very true! Didn't catch that.

@thecoolwinter thecoolwinter merged commit 00bb66f into CodeEditApp:main Feb 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants