Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix: #233) Fix TextFormation editing #239

Merged
merged 6 commits into from
Mar 1, 2024
Merged

(fix: #233) Fix TextFormation editing #239

merged 6 commits into from
Mar 1, 2024

Conversation

thecoolwinter
Copy link
Collaborator

@thecoolwinter thecoolwinter commented Feb 29, 2024 •
edited
Loading

Description

  • Cleans up undo/redo operations when TextFormation is activated, for instance when inserting or deleting a newline.

Note: Requires CodeEditTextView#25 to be merged. Merged!

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2024-03-01.at.1.30.22.PM.mov

@thecoolwinter thecoolwinter marked this pull request as draft February 29, 2024 20:07
@thecoolwinter thecoolwinter mentioned this pull request Feb 29, 2024
Merged
6 tasks
@thecoolwinter thecoolwinter marked this pull request as ready for review March 1, 2024 19:32
@thecoolwinter thecoolwinter merged commit a72e6c9 into CodeEditApp:main Mar 1, 2024
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/textformation-editing branch March 1, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

@matthijseikelenboom matthijseikelenboom Awaiting requested review from matthijseikelenboom

@tom-ludwig tom-ludwig Awaiting requested review from tom-ludwig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 Text Formation edits not registered with Undo Manager
2 participants
@thecoolwinter @austincondiff