Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always Show Highlights After Applying #288

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Always Show Highlights After Applying #288

merged 2 commits into from
Jan 8, 2025

Conversation

thecoolwinter
Copy link
Collaborator

Description

  • Invalidates highlighted ranges in the layout manager after applying highlights. This fixes highlights not appearing after undoing/redoing edits. The code doing this was commented out in Multiple Highlighter Support #273. It was likely missed because that was such a large PR.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

CodeEdit 0.3.3

Screen.Recording.2025-01-08.at.1.04.37.PM.mov

After Changes

Screen.Recording.2025-01-08.at.1.04.19.PM.mov

@thecoolwinter thecoolwinter merged commit 2810b76 into CodeEditApp:main Jan 8, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/undo-not-highlighted branch January 8, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecoolwinter @austincondiff