Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Text Artifacts, Fix Layout Bug, Public Undo Manager #23

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

thecoolwinter
Copy link
Contributor

Description

  • Reduces text drawing artifacts by turning off font smoothing, enabling subpixel positioning and font quantization, and a hidden smoothing API.
  • Adds an internal ObjC target to accomplish the previous point.
  • Fixes a layout bug where layout bounds would be nearly infinite due to the view being told to lay out but not be in the view hierarchy yet, causing a hang and memory explosion as every line in a potentially large document is laid out and rendered.
  • Fixes a small bug with the undo manager's grouping behavior and makes it public (for a fix in CESE for undo-redo related bugs), as well as reordering some notifications in the undo manager.

Related Issues

  • N/A

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Before:
Screenshot 2024-02-12 at 2 03 35 PM

After (left CE, right Xcode):
Screenshot 2024-02-13 at 2 23 36 PM

@thecoolwinter thecoolwinter merged commit e4d4853 into CodeEditApp:main Feb 21, 2024
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/blurry-drawing branch February 21, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants