Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move All Delegate Calls Outside Layout Pass #57

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

thecoolwinter
Copy link
Contributor

@thecoolwinter thecoolwinter commented Nov 17, 2024

Description

  • Moves a few more delegate calls or delegate triggering calls outside the protected area in layoutLines to prevent crashes. These are safe to call outside the intended protected area.
  • Documents an important layout method.
  • Fixes a flaking test by sorting selection ranges after deleting.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

N/A

@thecoolwinter thecoolwinter added the bug Something isn't working label Nov 17, 2024
Copy link
Member

@tom-ludwig tom-ludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but could you create an issue and reference it here before we merge? Matties always stressed the importance of having an issue first to make it easier to understand the history of merged PRs

@thecoolwinter
Copy link
Contributor Author

looks good, but could you create an issue and reference it here before we merge? Matties always stressed the importance of having an issue first to make it easier to understand the history of merged PRs

Absolutely, referenced as #58.

@thecoolwinter thecoolwinter merged commit 509d7b2 into CodeEditApp:main Nov 18, 2024
2 checks passed
@thecoolwinter thecoolwinter deleted the fix/layout-assertion branch November 18, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 Layout Pass Protection
2 participants