-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update mediacloud url to civicsignal url #2
Conversation
@@ -255,7 +255,7 @@ None. | |||
|
|||
Fetching information on The New York Times | |||
|
|||
URL: https://api.mediacloud.org/api/v2/media/single/1 | |||
URL: https://app.civicsignal.africa:8082/api/v2/media/single/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't we removing all ports?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thepsalmist mentioned that the ports are exposed to the frontend apps. @kilemensi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool @VinneyJ ... my question is do we want to do this moving forward or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, @kilemensi, this is not the ideal approach. I recommend changing the port exposure. I will discuss this further with @thepsalmist to see how we can approach removing them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VinneyJ LGTM once the exposed port issue is addressed.
Hello @kilemensi / @thepsalmist since I cloned the repo again let's merge this then I bring in the new changes. What do you say? |
It's one file @VinneyJ, isn't it easier to copy it to the new repo and create a new PR? |
Yes @kilemensi that can be another approach. |
is this PR still valid seeing as we have the updated one? @VinneyJ |
Nah, this should automatically be closed once #4 is merged. |
Updated the base api URLs from https://api.mediacloud.org/ to https://app.civicsignal.africa:8082/ in api_2_0_spec documention.