chore: update mediacloud url to civicsignal url #2
Conversation
VinneyJ
requested review from
kilemensi,
m453h,
DavidTheProgrammer,
koechkevin,
kelvinkipruto and
thepsalmist
| @@ -255,7 +255,7 @@ None. | |||
|
|
|||
| Fetching information on The New York Times | |||
|
|
|||
| URL: https://api.mediacloud.org/api/v2/media/single/1 | |||
| URL: https://app.civicsignal.africa:8082/api/v2/media/single/1 | |||
There was a problem hiding this comment.
Aren't we removing all ports?
There was a problem hiding this comment.
@thepsalmist mentioned that the ports are exposed to the frontend apps. @kilemensi
There was a problem hiding this comment.
Cool @VinneyJ ... my question is do we want to do this moving forward or not?
There was a problem hiding this comment.
No, @kilemensi, this is not the ideal approach. I recommend changing the port exposure. I will discuss this further with @thepsalmist to see how we can approach removing them.
|
Hello @kilemensi / @thepsalmist since I cloned the repo again let's merge this then I bring in the new changes. What do you say? |
|
It's one file @VinneyJ, isn't it easier to copy it to the new repo and create a new PR? |
|
Yes @kilemensi that can be another approach. |
|
is this PR still valid seeing as we have the updated one? @VinneyJ |
|
Nah, this should automatically be closed once #4 is merged. |
Updated the base api URLs from https://api.mediacloud.org/ to https://app.civicsignal.africa:8082/ in api_2_0_spec documention.