-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft/climatemapped_data_indicators #951
Conversation
@CodeForAfrica/tech ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code mostly looks good 🚀
Only wondering if there is any specific reason to not switch to sx
instead of @mui/styles
?
apps/climatemappedafrica/src/components/DataIndicators/useStyles.js
Outdated
Show resolved
Hide resolved
apps/climatemappedafrica/src/components/DataIndicators/DataIndicators.js
Outdated
Show resolved
Hide resolved
Mui Styles is deprecated @m453h |
Ah, had them mixed up 🤦 ... I was only interested on finding out if there was a particular reason for not styling the components using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
apps/climatemappedafrica/src/components/DataIndicators/IndicatorPanel.js
Outdated
Show resolved
Hide resolved
apps/climatemappedafrica/src/components/DataIndicators/DataIndicators.js
Outdated
Show resolved
Hide resolved
apps/climatemappedafrica/src/components/DataIndicators/DataIndicators.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽 ... can still do a bit of clean up on the sx styling but I guess we've other stories to get to.
Description
Adds Data indicators Climate mapped Africa
Fixes #918
Type of change
Please delete options that are not relevant.
Screenshots
Checklist: