Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ft/climatemapped_data_indicators #951

Merged
merged 18 commits into from
Oct 24, 2024
Merged

Ft/climatemapped_data_indicators #951

merged 18 commits into from
Oct 24, 2024
+458 −2

Conversation

koechkevin
Copy link
Contributor

@koechkevin koechkevin commented Oct 14, 2024 •
edited
Loading

Description

Adds Data indicators Climate mapped Africa

Fixes #918

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Screenshots

image image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin self-assigned this Oct 14, 2024
@koechkevin koechkevin marked this pull request as draft October 14, 2024 12:06
@koechkevin koechkevin changed the base branch from main to ft/climatemapped_hero October 18, 2024 12:28
Base automatically changed from ft/climatemapped_hero to main October 22, 2024 07:43
@koechkevin koechkevin marked this pull request as ready for review October 22, 2024 09:34
@koechkevin koechkevin requested a review from a team October 22, 2024 09:34
@kilemensi
Copy link
Member

@CodeForAfrica/tech ?

m453h
m453h approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@m453h m453h left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code mostly looks good 🚀

Only wondering if there is any specific reason to not switch to sx instead of @mui/styles ?

@koechkevin
Copy link
Contributor Author

Code mostly looks good 🚀

Only wondering if there is any specific reason to not switch to sx instead of @mui/styles ?

Mui Styles is deprecated @m453h

@m453h
Copy link
Contributor

m453h commented Oct 23, 2024

Code mostly looks good 🚀
Only wondering if there is any specific reason to not switch to sx instead of @mui/styles ?

Mui Styles is deprecated @m453h

Ah, had them mixed up 🤦 ... I was only interested on finding out if there was a particular reason for not styling the components using sx as its been the direction we are trying to go with

kilemensi
kilemensi reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

apps/climatemappedafrica/src/payload/fields/richText.js Outdated Show resolved Hide resolved
apps/climatemappedafrica/src/payload/blocks/DataIndicators.js Outdated Show resolved Hide resolved
apps/climatemappedafrica/src/components/RichHeader/RichHeader.js Show resolved Hide resolved
apps/climatemappedafrica/src/components/DataIndicators/IndicatorPanel.js Outdated Show resolved Hide resolved
apps/climatemappedafrica/src/components/DataIndicators/Icon.js Outdated Show resolved Hide resolved
apps/climatemappedafrica/src/components/DataIndicators/DataIndicators.js Outdated Show resolved Hide resolved
apps/climatemappedafrica/src/components/DataIndicators/DataIndicators.js Outdated Show resolved Hide resolved
kilemensi
kilemensi approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 ... can still do a bit of clean up on the sx styling but I guess we've other stories to get to.

apps/climatemappedafrica/src/components/DataIndicators/DataIndicators.js Outdated Show resolved Hide resolved
apps/climatemappedafrica/src/components/DataIndicators/DataIndicators.js Outdated Show resolved Hide resolved
apps/climatemappedafrica/src/components/DataIndicators/DataIndicators.js Outdated Show resolved Hide resolved
apps/climatemappedafrica/src/payload/blocks/DataIndicators.js Show resolved Hide resolved
@koechkevin koechkevin added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit ee13cbf Oct 24, 2024
4 checks passed
@koechkevin koechkevin deleted the ft/climatemapped_data_indicators branch October 24, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilemensi kilemensi kilemensi approved these changes

@m453h m453h m453h approved these changes

@kelvinkipruto kelvinkipruto kelvinkipruto approved these changes

Assignees

@koechkevin koechkevin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClimateMapped Data Indicators Block
4 participants
@koechkevin @kilemensi @m453h @kelvinkipruto