Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering for only main zones #1064

Conversation

DonovanAndrews300
Copy link
Contributor

@DonovanAndrews300 DonovanAndrews300 commented Dec 30, 2024

Description
This PR updates the zoning filter dropdown to display only main zones as filter options, while automatically applying the corresponding subzones. Additionally, the PR introduces a feature allowing users to search for specific filter options by typing directly into any dropdown. See issue #1058

Steps to Test

  1. Navigate to the property map.
  2. Open the filter pane.
  3. Check the Zoning filters to verify that only main zones are listed as filter options.
  4. Confirm that all main zones are correctly listed.
  5. Ensure that selecting a main zone applies all relevant subzones.
  6. While focused on any filter dropdown, type to search for specific options.

Screenshots
Screencast from 12-29-2024 09:17:00 PM.webm

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 7:26pm

@CodeWritingCow
Copy link
Collaborator

CodeWritingCow commented Jan 1, 2025

@DonovanAndrews300 PR has a merge conflict. Can you resolve it when you get a chance? Thank you!

@CodeWritingCow
Copy link
Collaborator

@nlebovits this is a front-end PR, but the backend PR checks are failing. That's probably causing Vercel deployment to fail as well. I'm not sure why. Can you take a look?

@nlebovits
Copy link
Collaborator

@CodeWritingCow There are 62 files changed on this PR. I think @DonovanAndrews300 needs to rebase against staging before anything else and figure out where his feature branch diverged, and then commit only the files actually relevant to the PR. There shouldn't be anything changed in the data subdirectory, for example.

@DonovanAndrews300
Copy link
Contributor Author

Got it, thanks for pointing that out. I initially just merged staging onto my feature branch. I’ll rebase and clean up the PR to remove the unrelated changes to the PR. I appreciate the heads-up!

@DonovanAndrews300
Copy link
Contributor Author

What I did to resolve was revert to the original commit, stashed my changes, and rebased on the staging branch. This removed the unintended changes from staging that had been included in the PR.

Copy link
Collaborator

@CodeWritingCow CodeWritingCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonovanAndrews300 PR looks good to me. Thanks!

@CodeWritingCow CodeWritingCow requested review from nlebovits and removed request for zigouras January 5, 2025 01:11
@CodeWritingCow CodeWritingCow removed the request for review from nlebovits January 5, 2025 01:13
@CodeWritingCow
Copy link
Collaborator

Hi @soskin can you take a quick look at the preview for this PR? And see if it meets the requirements for your ticket #1058? Thank you!

Preview URL: https://vacant-lots-proj-jgvc5rt9l-clean-and-green-philly.vercel.app/find-properties

@CodeWritingCow CodeWritingCow merged commit 61c15b3 into CodeForPhilly:staging Jan 8, 2025
5 checks passed
@CodeWritingCow
Copy link
Collaborator

HI @DonovanAndrews300 I'm reverting this PR for now. I found a bug while testing it on the staging branch. When user clicks any of the "Suggested Priority" filters, all properties disappear from the map. See screen recording:

Screen.Recording.2025-01-09.at.11.57.44.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants