-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering for only main zones #1064
Filtering for only main zones #1064
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@DonovanAndrews300 PR has a merge conflict. Can you resolve it when you get a chance? Thank you! |
@nlebovits this is a front-end PR, but the backend PR checks are failing. That's probably causing Vercel deployment to fail as well. I'm not sure why. Can you take a look? |
@CodeWritingCow There are 62 files changed on this PR. I think @DonovanAndrews300 needs to rebase against staging before anything else and figure out where his feature branch diverged, and then commit only the files actually relevant to the PR. There shouldn't be anything changed in the |
Got it, thanks for pointing that out. I initially just merged staging onto my feature branch. I’ll rebase and clean up the PR to remove the unrelated changes to the PR. I appreciate the heads-up! |
01d5f66
to
406042f
Compare
What I did to resolve was revert to the original commit, stashed my changes, and rebased on the staging branch. This removed the unintended changes from staging that had been included in the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonovanAndrews300 PR looks good to me. Thanks!
Hi @soskin can you take a quick look at the preview for this PR? And see if it meets the requirements for your ticket #1058? Thank you! Preview URL: https://vacant-lots-proj-jgvc5rt9l-clean-and-green-philly.vercel.app/find-properties |
HI @DonovanAndrews300 I'm reverting this PR for now. I found a bug while testing it on the staging branch. When user clicks any of the "Suggested Priority" filters, all properties disappear from the map. See screen recording: Screen.Recording.2025-01-09.at.11.57.44.PM.mov |
Description
This PR updates the zoning filter dropdown to display only main zones as filter options, while automatically applying the corresponding subzones. Additionally, the PR introduces a feature allowing users to search for specific filter options by typing directly into any dropdown. See issue #1058
Steps to Test
Screenshots
Screencast from 12-29-2024 09:17:00 PM.webm